Repository navigation
fix: keep generated phone numbers well formed - #1137
Closed
andreatnvidia wants to merge 1 commit into
Closed
andreatnvidia wants to merge 1 commit into
andreatnvidia wants to merge 1 commit into
Conversation
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #1134, which now includes this fix and its regression tests.
Summary
Generated phone numbers could contain a four-digit exchange (
1000) or a five-digit line number (10000) becauserandintincludes its upper bound. Correct both ranges and resample N11 exchanges, which NANPA lists as unavailable for assignment.Related Issue
Found during review of #1134. Kept separate from that data-provenance change.
Changes
Testing
Checklist