Repository navigation
fix: replace retired gpt-5 and gpt-4.1 with gpt-5.6-luna in OpenAI default models #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -349,6 +349,7 @@ class NordColor(Enum): | |
| } | ||
| NEMOTRON_3_NANO_OMNI_30B_A3B_REASONING_INFERENCE_PARAMS = {"temperature": 0.60, "top_p": 0.95} | ||
| GPT5_INFERENCE_PARAMS = {"extra_body": {"reasoning_effort": "medium"}} | ||
| GPT5_TEXT_INFERENCE_PARAMS = DEFAULT_TEXT_INFERENCE_PARAMS | {"extra_body": {"reasoning_effort": "none"}} | ||
|
|
||
| PREDEFINED_PROVIDERS_MODEL_MAP = { | ||
| NVIDIA_PROVIDER_NAME: { | ||
|
|
@@ -370,9 +371,9 @@ class NordColor(Enum): | |
| }, | ||
| }, | ||
| OPENAI_PROVIDER_NAME: { | ||
| "text": {"model": "gpt-4.1", "inference_parameters": DEFAULT_TEXT_INFERENCE_PARAMS}, | ||
| "reasoning": {"model": "gpt-5", "inference_parameters": GPT5_INFERENCE_PARAMS}, | ||
| "vision": {"model": "gpt-5", "inference_parameters": GPT5_INFERENCE_PARAMS}, | ||
| "text": {"model": "gpt-5.6-luna", "inference_parameters": GPT5_TEXT_INFERENCE_PARAMS}, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thereβs another compatibility detail with openai-text: calls that set max_tokens worked with GPT-4.1, but Luna rejects that parameter and asks for max_completion_tokens, even with reasoning disabled. It looks like DD forwards it unchanged. Translating the limit for the affected OpenAI models, with a test for an explicit token limit, would help preserve those calls. |
||
| "reasoning": {"model": "gpt-5.6-luna", "inference_parameters": GPT5_INFERENCE_PARAMS}, | ||
| "vision": {"model": "gpt-5.6-luna", "inference_parameters": GPT5_INFERENCE_PARAMS}, | ||
|
Comment on lines
+375
to
+376
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Iβm seeing a compatibility issue with MCP tools here: Luna returns HTTP 400 for function tools with reasoning_effort="medium" through Chat Completions. The same exchange works with GPT-5, and with Luna when reasoning is disabled. Would it make sense to revisit the interim configuration in #1129 so these aliases keep working with tools while Responses support is pending? |
||
| "embedding": {"model": "text-embedding-3-large", "inference_parameters": DEFAULT_EMBEDDING_INFERENCE_PARAMS}, | ||
| }, | ||
| OPENROUTER_PROVIDER_NAME: { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small YAML example might make this migration easier. If someone changes only the model name, the saved temperature and top_p values remain, but reasoning_effort="none" is missing, which returned HTTP 400 in my check. Showing the inference parameters alongside the model would help users update without resetting their custom configs.