ci: validate release branch-rules#192
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
70bece7 to
d65b018
Compare
|
/ok to test d65b018 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
82bfd94 to
bcb6cc9
Compare
|
/ok to test bcb6cc9 |
bcb6cc9 to
bdd27e7
Compare
|
/ok to test bdd27e7 |
bdd27e7 to
2c7ad95
Compare
|
/ok to test 2c7ad95 |
2c7ad95 to
48c060b
Compare
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test fbf56a9 |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 83e66aa |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 391f423 |
Greptile SummaryBumps the
Confidence Score: 4/5The change is a single-line version bump in a CI workflow and introduces no new logic in this repository. The bump from v1.1.0 to v1.4.0 is straightforward; the only concern is that the PR description still refers to an unmerged SHA and 'do not merge' while the code uses a proper tag — worth confirming before landing. release.yaml — confirm the draft / 'do not merge' status and description are accurate before merging. Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions
participant PF as pre-flight(v0.94.1)
participant RL as release(v1.4.0 was v1.1.0)
participant RS as release-summary
GH->>PF: push / workflow_dispatch triggers
PF-->>GH: docs_only, is_deployment_workflow outputs
GH->>RL: "if !cancelled && !failure && !docs_only && !deploy"
Note over RL: bump-next-version runs Mirror branch protection step new in v1.4.0
RL-->>GH: release artifacts / dry-run output
GH->>RS: always runs (!cancelled)
RS-->>GH: pass/fail summary
Reviews (1): Last reviewed commit: "ci: re-pin FW-CI-templates from SHA to v..." | Re-trigger Greptile |
| && !(needs.pre-flight.outputs.docs_only == 'true' | ||
| || needs.pre-flight.outputs.is_deployment_workflow == 'true') | ||
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.1.0 | ||
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.4.0 |
There was a problem hiding this comment.
PR description out of sync with the actual change
The PR description states the workflow is "pinned to an unmerged SHA" (042e967e4ac9652c324cbd5b78fd126c089aec6c) and is marked "do not merge", but the committed change references the released tag v1.4.0. If FW-CI-templates#480 has already landed and been tagged as v1.4.0, the draft status and description should be updated to reflect that before this is merged to avoid confusion for future maintainers.
Claude summary
Companion to NVIDIA-NeMo/FW-CI-templates#480, which mirrors the branch-protection rule of
[rv][0-9].[0-9].[0-9]ontodeploy-release/*so the validate-only release rehearsal is gated by the same required status checks as a real release.Change
Bumps the FW-CI-templates pin in
release.yamlto commit042e967e4ac9652c324cbd5b78fd126c089aec6c(the head ofko3n1g/feat/mirror-release-branch-protectionon FW-CI-templates).What's being validated
After merge of FW-CI-templates#480, a workflow-dispatch of
release.yamlwithdry-run: trueshould:bump-next-version.deploy-release/*rule on this repo to match[rv][0-9].[0-9].[0-9].Nemo_CICD_Test(or the repo's equivalent) shown as a required check.Prerequisites
The
nemo-automation-botGitHub App must holdadministration: writeat the org installation, otherwise the mirror step fails the bump.Rollout
This PR is draft + do not merge — pinned to an unmerged SHA. Once FW-CI-templates#480 lands and ships in a new tag, re-pin to that tag and merge.