Skip to content

ci: validate release branch-rules#192

Merged
ko3n1g merged 5 commits into
mainfrom
ko3n1g/ci/pin-fw-ci-pr-480
May 27, 2026
Merged

ci: validate release branch-rules#192
ko3n1g merged 5 commits into
mainfrom
ko3n1g/ci/pin-fw-ci-pr-480

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented May 22, 2026

Claude summary

Companion to NVIDIA-NeMo/FW-CI-templates#480, which mirrors the branch-protection rule of [rv][0-9].[0-9].[0-9] onto deploy-release/* so the validate-only release rehearsal is gated by the same required status checks as a real release.

Change

Bumps the FW-CI-templates pin in release.yaml to commit 042e967e4ac9652c324cbd5b78fd126c089aec6c (the head of ko3n1g/feat/mirror-release-branch-protection on FW-CI-templates).

What's being validated

After merge of FW-CI-templates#480, a workflow-dispatch of release.yaml with dry-run: true should:

  1. Run the new "Mirror branch protection" step in bump-next-version.
  2. Update the deploy-release/* rule on this repo to match [rv][0-9].[0-9].[0-9].
  3. Open the bump PR with Nemo_CICD_Test (or the repo's equivalent) shown as a required check.
  4. Block merge of the bump until the required checks pass.

Prerequisites

The nemo-automation-bot GitHub App must hold administration: write at the org installation, otherwise the mirror step fails the bump.

Rollout

This PR is draft + do not merge — pinned to an unmerged SHA. Once FW-CI-templates#480 lands and ships in a new tag, re-pin to that tag and merge.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 22, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 22, 2026

/ok to test d65b018

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Test Results

   52 files  ±0    114 suites  ±0   1m 35s ⏱️ +8s
1 067 tests ±0  1 067 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 385 runs  ±0  2 385 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 391f423. ± Comparison against base commit 1338dc4.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ko3n1g ko3n1g force-pushed the ko3n1g/ci/pin-fw-ci-pr-480 branch 2 times, most recently from 82bfd94 to bcb6cc9 Compare May 22, 2026 12:28
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 22, 2026

/ok to test bcb6cc9

@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 22, 2026

/ok to test bdd27e7

@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 22, 2026

/ok to test 2c7ad95

@ko3n1g ko3n1g changed the title ci: pin FW-CI-templates to NVIDIA-NeMo/FW-CI-templates#480 (mirror branch protection) ci: validate release branch-rules May 25, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 25, 2026

/ok to test fbf56a9

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 25, 2026

/ok to test 83e66aa

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 27, 2026

/ok to test 391f423

@ko3n1g ko3n1g marked this pull request as ready for review May 27, 2026 06:59
@ko3n1g ko3n1g requested a review from a team as a code owner May 27, 2026 06:59
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

Bumps the FW-CI-templates/_release_library.yml reusable workflow pin from v1.1.0 to v1.4.0, enabling the new "Mirror branch protection" step that gates deploy-release/* branches with the same required status checks as real releases.

  • The single-line version bump in release.yaml upgrades the release job to v1.4.0; the pre-flight job intentionally stays at its own pin (v0.94.1), which is unrelated to the release-library versioning track.
  • The PR description refers to pinning an unmerged SHA (042e967…) and is marked "do not merge", but the actual committed change uses the released tag v1.4.0. If FW-CI-templates#480 has since shipped as v1.4.0, the description should be updated to reflect that before merging.

Confidence Score: 4/5

The change is a single-line version bump in a CI workflow and introduces no new logic in this repository.

The bump from v1.1.0 to v1.4.0 is straightforward; the only concern is that the PR description still refers to an unmerged SHA and 'do not merge' while the code uses a proper tag — worth confirming before landing.

release.yaml — confirm the draft / 'do not merge' status and description are accurate before merging.

Important Files Changed

Filename Overview
.github/workflows/release.yaml Bumps the _release_library.yml reusable workflow pin from v1.1.0 to v1.4.0; pre-flight retains v0.94.1 — the two jobs intentionally track different versioning series.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant PF as pre-flight(v0.94.1)
    participant RL as release(v1.4.0 was v1.1.0)
    participant RS as release-summary

    GH->>PF: push / workflow_dispatch triggers
    PF-->>GH: docs_only, is_deployment_workflow outputs
    GH->>RL: "if !cancelled && !failure && !docs_only && !deploy"
    Note over RL: bump-next-version runs Mirror branch protection step new in v1.4.0
    RL-->>GH: release artifacts / dry-run output
    GH->>RS: always runs (!cancelled)
    RS-->>GH: pass/fail summary
Loading

Reviews (1): Last reviewed commit: "ci: re-pin FW-CI-templates from SHA to v..." | Re-trigger Greptile

&& !(needs.pre-flight.outputs.docs_only == 'true'
|| needs.pre-flight.outputs.is_deployment_workflow == 'true')
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.1.0
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v1.4.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PR description out of sync with the actual change

The PR description states the workflow is "pinned to an unmerged SHA" (042e967e4ac9652c324cbd5b78fd126c089aec6c) and is marked "do not merge", but the committed change references the released tag v1.4.0. If FW-CI-templates#480 has already landed and been tagged as v1.4.0, the draft status and description should be updated to reflect that before this is merged to avoid confusion for future maintainers.

@ko3n1g ko3n1g merged commit 3e86f89 into main May 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants