Repository navigation
Conversation
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
[Low impact] The PR appears safe to merge for its intended 0.25.0 launch. SummaryReworks the README around agent workflows and removes the release workflow's README updater.
Reviews (6) · Last reviewed commit: "ci: correct the pinned release action ve..." · Reviewed by Greptile |
| Third-party endpoints have separate terms and privacy practices. The NVIDIA NeMo Guardrails library can use inference endpoints such as NVIDIA Build (`build.nvidia.com`). If you use NVIDIA Build or another third-party endpoint, that endpoint's terms of service and privacy practices apply independently of the library. Any telemetry opt-out in the NVIDIA NeMo Guardrails library does not extend to the endpoint you choose. NVIDIA Build is intended for evaluation and testing only and must not be used in production environments. Do not submit confidential information or personal data when using NVIDIA Build. | ||
|
|
||
| ## Inviting the community to contribute | ||
| Refer to [telemetry and privacy](https://docs.nvidia.com/nemo/guardrails/latest/resources/telemetry) for the full schema, local audit file, opt-out options, and third-party endpoint terms. |
There was a problem hiding this comment.
Promised privacy guidance is missing
The linked page only covers library telemetry; it does not contain the promised third-party endpoint terms. This PR also removes the README's explanation that third-party services have separate privacy terms and that the library's opt-out does not cover them. Readers following this link cannot find that guidance. Move it into the linked page or link to a page that contains it.
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 253
Comment:
**Promised privacy guidance is missing**
The linked page only covers library telemetry; it does not contain the promised third-party endpoint terms. This PR also removes the README's explanation that third-party services have separate privacy terms and that the library's opt-out does not cover them. Readers following this link cannot find that guidance. Move it into the linked page or link to a page that contains it.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
This finding is outdated at the current PR head. The original wording was corrected in c88c161 and the relevant disclosure is retained in the current Telemetry and Privacy section.
The README no longer promises that the telemetry page contains third-party endpoint terms. It also explicitly states that the usage-telemetry opt-out does not disable configured model or guardrail service calls, and that those calls can send content to their endpoints.
The linked telemetry guide is now offered for telemetry details and opt-out options. The current README therefore addresses the missing disclosure and removes the inaccurate link promise. Please remove this already-addressed finding from the review summary.
There was a problem hiding this comment.
Agreed. The current README has corrected the link’s scope and explicitly discloses that configured model or guardrail service calls can send content to their endpoints, regardless of the usage-telemetry opt-out. This finding is addressed and should be removed from the review summary.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Project framing and release updates README.md, .github/workflows/release.yml |
The README introduces configurable checks for agent workflows and updates project links. The release workflow stops editing the README and removes the related pull request text and path entry. |
Check workflow and quickstart README.md |
The README explains check verdicts and tool execution boundaries, then adds a refund-tool example using a CEL rule, check_async(), and IORails. |
Deployment and check coverage README.md |
The README describes the HTTP proxy, coding-agent hooks, framework integration, check coverage, and supported engines. |
Telemetry and project policies README.md |
The README shortens its telemetry description and updates contribution, license, and citation links. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested labels: documentation
Suggested reviewers: pouyanpi
Merge Risk: 
Minimal · up to bec71
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
5
-
Full details: Test Results For Major Changes
-
Explanation
The PR makes a substantial README and release-workflow documentation change. Its description includes testing information: a network-disabled quickstart run, seven policy and schema boundary checks, target and URL validation, pre-commit, diff, and documentation checks. No numeric, convergence, or performance change is introduced.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
tgasser-nv
left a comment
There was a problem hiding this comment.
Thanks for the PR @miyoungc. This has good coverage of agentic use-cases, but is missing all the other capabilities of Guardrails. We still support a range of rails for conversational, RAG, etc. We need to add these into the README as well.
Recommend adding a section at the top with all the use-cases we support including conversational application with input and output rails, RAG, etc. Then each of these can link to a more detailed section below with further information. The PR as it is will be good for agentic / tool-calling usecases
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
| - **AI agents and coding assistants:** Check proposed tool calls and returned results with [tool rails](./docs/configure-rails/guardrail-catalog/tool-calling.mdx), or connect an agent through the [hooks server](./docs/run-rails/using-hooks-server/index.mdx). | ||
| - **Conversational applications:** Apply [input and output checks](./docs/run-rails/using-python-apis/check-messages.mdx) and define dialog behavior with [Colang](./docs/configure-rails/colang/index.mdx). | ||
| - **Retrieval-augmented generation (RAG):** [Detect or mask sensitive data in retrieved content](./docs/configure-rails/guardrail-catalog/pii-detection.mdx) and [check whether answers are grounded in evidence](./docs/configure-rails/guardrail-catalog/fact-checking.mdx). |
There was a problem hiding this comment.
shall we add ?
guardrailing/securing model provider API's through the serveror the experimental guardrails proxy
| - [Security Guidelines](https://docs.nvidia.com/nemo/guardrails/security/guidelines.html) | ||
| Use the [evaluation tools](https://docs.nvidia.com/nemo/guardrails/latest/evaluation) to assess your policies and [garak](https://github.com/NVIDIA/garak) to scan LLM applications for vulnerabilities. Refer to the [vulnerability-scanning guide](./docs/evaluation/llm-vulnerability-scanning.mdx) for an example. | ||
|
|
||
| ## Telemetry and Privacy |
There was a problem hiding this comment.
I’m not sure whether the requirements have changed, but the original decision was to include these telemetry metrics in the README as a way of giving back to the community.
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Description
Position the GitHub overview around programmable safeguards for agents, with concise use cases for conversations, RAG, and model-provider APIs. Explain policy configuration, workflow checks, and application enforcement in three bullets. Consolidate capabilities into “Why NeMo Guardrails” and provide twelve linked catalog entries, named Nemotron Safety models, and garak evaluation guidance.
Keep the complete, package-based refund quickstart and all three historical community-usage charts in expandable sections. The quickstart prints the blocking rail and reason; the community snapshot retains its release/date scope, estimated counts, aggregate data, and methodology. Link detailed model, integration, and deployment instructions to the documentation.
Align Python requirements with the launch package (3.11–3.13), add security/release navigation, and remove the hard-coded release marker and its dependent workflow updater. The PR changes only README.md and .github/workflows/release.yml.
Preview: https://github.com/NVIDIA-NeMo/Guardrails/blob/miyoungc/ngr-1020-guardrails-github-overview-update/README.md
Related Issue(s)
The tracking issue is in Linear; there is no linked triaged GitHub issue.
Verification
0.25.0rc1from the updated branch and installed its[cel]extra with all runtime dependencies in a fresh Python 3.13 environment. Ran the exact README script outside the checkout with network connections prohibited. Output, blocking rail/reason, and seven additional policy/schema cases passed.uv run --locked pre-commit run --files README.md .github/workflows/release.ymlandgit diff --checkpassed.make docs-ferngenerated 440 SDK reference pages and passed with 0 errors and 566 warnings. Used the existing cached SDK parser image after its remote image pull stalled; the cache override was local only.v8.1.1, matching its unchanged pinned hash.The package install flow targets publication with the 0.25.0 launch. Validation used the current release-candidate wheel, not a published GA package.
Source references
AI Assistance
Codex helped prepare the README and perform local verification. Human review is pending.
Checklist
Summary by CodeRabbit