Skip to content

fix(translation): reject duplicate tool names in Chat and Anthropic requests #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grahamking merged 2 commits into from
Nov 10, 2026
Merged

fix(translation): reject duplicate tool names in Chat and Anthropic requests #1278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f6d15f
fix(translation): reject duplicate Chat Completions tool names
dagardner-nv Nov 10, 2026
f8cf28f
fix(translation): reject duplicate Anthropic tool names
dagardner-nv Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/switchyard-translation/src/codecs/anthropic/buffered.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,6 +1263,7 @@ fn ensure_anthropic_tool_input_object(arguments: Value) -> Value {

// Encodes normalized tool definitions into Anthropic tool JSON.
fn encode_anthropic_tools(tools: &[Tool]) -> Result<Value> {
let mut names = std::collections::HashSet::new();
Ok(Value::Array(
tools
.iter()
Expand All @@ -1277,6 +1278,12 @@ fn encode_anthropic_tools(tools: &[Tool]) -> Result<Value> {
"MCP and provider tool encoding is not implemented".into(),
)
})?;
if !names.insert(tool.name.as_str()) {
return Err(TranslationError::InvalidValue {
path: "$.tools".to_string(),
message: format!("duplicate tool name: {:?}", tool.name),
});
}
let mut item = json!({
"name": tool.name,
"description": tool.description.clone().unwrap_or_default(),
Expand Down
7 changes: 7 additions & 0 deletions crates/switchyard-translation/src/codecs/openai_chat/buffered.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,7 @@ fn media_source_text(source: &MediaSource) -> String {

/// Encodes normalized tool definitions into OpenAI tool JSON.
pub(crate) fn encode_openai_tools(tools: &[Tool]) -> Result<Value> {
let mut names = std::collections::HashSet::new();
Ok(Value::Array(
tools
.iter()
Expand All @@ -1211,6 +1212,12 @@ pub(crate) fn encode_openai_tools(tools: &[Tool]) -> Result<Value> {
"MCP and provider tool encoding is not implemented".into(),
)
})?;
if !names.insert(tool.name.as_str()) {
return Err(TranslationError::InvalidValue {
path: "$.tools".to_string(),
message: format!("duplicate tool name: {:?}", tool.name),
});
}
let mut function = json!({
"name": tool.name,
"description": tool.description.clone().unwrap_or_default(),
Expand Down
48 changes: 48 additions & 0 deletions tests/test_translation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,54 @@ def test_response_ir_restores_request_tool_extensions(method) -> None:
ValueError,
id="request",
),
pytest.param(
"translate_request",
(
"openai_responses",
"openai_chat",
{
"tools": [
{
"type": "namespace",
"name": "a__b",
"tools": [{"type": "function", "name": "c", "parameters": {}}],
},
{
"type": "namespace",
"name": "a",
"tools": [{"type": "function", "name": "b__c", "parameters": {}}],
},
],
},
),
{},
TranslationError,
id="namespace-tool-name-collision",
),
pytest.param(
"translate_request",
(
"openai_responses",
"anthropic_messages",
{
"tools": [
{
"type": "namespace",
"name": "a__b",
"tools": [{"type": "function", "name": "c", "parameters": {}}],
},
{
"type": "namespace",
"name": "a",
"tools": [{"type": "function", "name": "b__c", "parameters": {}}],
},
],
},
),
{},
TranslationError,
id="namespace-tool-name-collision-anthropic",
),
pytest.param(
"encode_response",
("openai_chat", {}),
Expand Down
Loading