Repository navigation
fix: build Linux Rust plugins for glibc and musl - #14
Merged
Merged
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux Rust plugin bundles need to match Relay's libc and architecture. Build the glibc bundles in pinned manylinux2014 images and add separate musllinux 1.2 bundles for x86-64 and ARM64. Each container runs the plugin's build, release-mode tests, packaging, and installed-bundle smoke test.
linux-musl-x86_64andlinux-musl-arm64platforms for the Rust plugins, with image digests matching Relay's CLI packaging.crt-staticso Relay can load the shared library.NODELETEflag. This prevents glibc 2.17 thread-local destructors from executing unloaded Rust code after Relay shuts down a plugin. Plugin callbacks and runtime instances still close normally.Related Relay changes: NVIDIA/NeMo-Relay#1242 selects the CLI binary by host libc. NVIDIA/NeMo-Relay#1243 dynamically links musl release packages and selects plugin bundles by the CLI's libc target. The platform names in this PR match that installer mapping. Plugin SDK pins and Relay test-host selectors remain separate.
Validation: 210 shared tests passed (one existing Windows-only test skipped on macOS), and all commit hooks passed. A minimal Rust library reproduction in the pinned manylinux2014 x86-64 image failed with SIGSEGV without
NODELETEand exited cleanly with it. The complete native-example pipeline then passed in that same glibc 2.17 image, including lifecycle tests, packaging, and installed-bundle shutdown. The macOS plugin pipelines passed, and the initial CI run passed musl native-plugin loading for both architectures. Updated cross-platform CI passed on commit79ddfe3: all 25 platform builds, repository checks, and the final plugin check passed. Native-plugin load and shutdown passed on both glibc and musl architectures.