Skip to content

refactor(node)!: ship TypeScript facade over internal N-API binding #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greysonlalonde wants to merge 4 commits into from
+4,014 −4,364
Open

refactor(node)!: ship TypeScript facade over internal N-API binding #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc08848
refactor(node)!: ship typescript facade over internal napi binding
greysonlalonde Nov 6, 2026
d063251
fix(node): resolve subpath typings under node10 module resolution
greysonlalonde Nov 9, 2026
87a93e0
fix(node): ship subpath typings, follow facade re-exports in docs, an…
greysonlalonde Nov 9, 2026
735ff4b
fix(docs): rebuild node declarations when binding.d.ts is missing
greysonlalonde Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/ci-path-filters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ node_package:
- 'crates/node/build.rs'
- 'crates/node/package.json'
- 'crates/node/src/**'
- 'crates/node/ts/**'
- 'crates/node/tsconfig.json'
- 'crates/observability/Cargo.toml'
- 'crates/observability/src/**'
- 'crates/plugin-host/Cargo.toml'
Expand Down Expand Up @@ -280,6 +282,8 @@ docs:
- 'crates/node/*.d.ts'
- 'crates/node/*.js'
- 'crates/node/package.json'
- 'crates/node/ts/**'
- 'crates/node/tsconfig.json'
- 'crates/observability/Cargo.toml'
- 'crates/observability/src/**'
- 'crates/plugin-host/src/**'
Expand All @@ -295,6 +299,7 @@ docs:
- 'python/nemo_relay/**'
- 'scripts/build-docs.sh'
- 'scripts/docs/**'
- 'scripts/tests/test_node_library_reference.py'
- 'scripts/tests/test_rust_library_reference.py'

rust:
Expand Down Expand Up @@ -330,7 +335,9 @@ node:
- 'crates/node/build.rs'
- 'crates/node/package.json'
- 'crates/node/src/**'
- 'crates/node/tests/**/*.mjs'
- 'crates/node/tests/**'
- 'crates/node/ts/**'
- 'crates/node/tsconfig.json'
- 'package-lock.json'
- 'package.json'
- 'scripts/test-support/**'
Expand Down
17 changes: 15 additions & 2 deletions .github/workflows/ci_node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ jobs:
const assert = require('node:assert/strict');
const { readFileSync, readdirSync } = require('node:fs');
const path = require('node:path');
const packageDir = path.dirname(require.resolve('nemo-relay-node'));
const packageDir = path.join(path.dirname(require.resolve('nemo-relay-node')), '..');
const manifest = JSON.parse(readFileSync(path.join(packageDir, 'package.json'), 'utf8'));
const nativePackages = readdirSync('node_modules').filter(
(name) => name.startsWith('nemo-relay-node-') && name !== 'nemo-relay-node',
Expand All @@ -490,6 +490,19 @@ jobs:
}
NODE

- name: Type-check split Node package entry points
if: ${{ !contains(matrix.platform, 'musl') }}
working-directory: package-smoke
run: |
set -euo pipefail
typescript_version="$(node -p "require('../package.json').devDependencies.typescript")"
npm install --ignore-scripts --no-save "typescript@${typescript_version}"
cp ../crates/node/tests/public_entry_points_fixture.ts .
for resolution in "CommonJS Node10" "NodeNext NodeNext" "ESNext Bundler"; do
read -r module module_resolution <<<"$resolution"
npx tsc --noEmit --strict --target ES2022 --module "$module" --moduleResolution "$module_resolution" public_entry_points_fixture.ts
done

- name: Install and load musllinux split Node package
if: ${{ contains(matrix.platform, 'musl') }}
run: |
Expand All @@ -516,7 +529,7 @@ jobs:
const assert = require(\"node:assert/strict\");
const { readFileSync, readdirSync } = require(\"node:fs\");
const path = require(\"node:path\");
const packageDir = path.dirname(require.resolve(\"nemo-relay-node\"));
const packageDir = path.join(path.dirname(require.resolve(\"nemo-relay-node\")), \"..\");
const packageManifest = JSON.parse(readFileSync(path.join(packageDir, \"package.json\"), \"utf8\"));
const manifest = require(process.env.NEMO_RELAY_NODE_PACKAGE_NAME + \"/package.json\");
const nativePackages = readdirSync(\"node_modules\").filter(
Expand Down
5 changes: 3 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ go/nemo_relay/nemo_relay_test.exe
# Node.js (NAPI-RS)
node_modules/
crates/node/*.node
crates/node/index.js
crates/node/index.d.ts
crates/node/binding.js
crates/node/binding.d.ts
crates/node/dist/
crates/node/coverage/
crates/node/junit.xml
integrations/openclaw/dist/
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,5 +283,5 @@ repos:
name: node docstrings check
entry: node scripts/lint/check_public_docstrings.mjs all
language: system
files: '^crates/node/(?:plugin|adaptive|typed)\.(?:js|d\.ts)$'
files: '^crates/node/ts/(?:plugin|adaptive|typed)\.ts$'
pass_filenames: false
3 changes: 2 additions & 1 deletion codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ component_management:
- component_id: node_binding
name: Node Binding
paths:
- "crates/node/*.js"
- "crates/node/binding.js"
- "crates/node/ts/**"
- component_id: plugin_sdk
name: Dynamic Plugin SDKs
paths:
Expand Down
Loading
Loading