Repository navigation
test(cli): cover dcode status harness label - #5817
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Vitest case for ChangesCLI status test coverage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
9 of 21 tasks
10 of 21 tasks
Hadar301
pushed a commit
to Hadar301/NemoClaw-OpenShift
that referenced
this pull request
Jul 12, 2026
<!-- markdownlint-disable MD041 --> ## Summary Adds a regression test for the Deep Agents Code status harness label reported in NVIDIA#5718. Current main already resolves a registered `langchain-deepagents-code` sandbox to `LangChain Deep Agents Code (terminal)`; this locks that user-facing status contract so it cannot regress to `OpenClaw (gateway)`. ## Related Issue Fixes NVIDIA#5718 ## Changes - Add CLI status text coverage for a registered `langchain-deepagents-code` sandbox named `dcode-station`. - Assert the exact harness line, dcode interactive/headless command hints, and terminal runtime line. - Assert the status output does not fall back to `Harness: OpenClaw (gateway)` or `OpenClaw: running`. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: test-only coverage for an existing documented status contract; docs already describe Deep Agents Code as a terminal harness and `status` as reporting the terminal runtime plus interactive/headless command shapes. - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: no sensitive production paths changed; this is CLI status regression coverage only. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [ ] Git hooks passed during commit and push, or `npx prek run --from-ref main --to-ref HEAD` passes - [x] Targeted tests pass for changed behavior - [ ] Full `npm test` passes (broad runtime changes only) - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) Verification detail: - `npx vitest run test/cli/sandbox-status-text.test.ts --project cli` passed (7 tests). - `npm run typecheck:cli` passed. - `SKIP=test-cli npx prek run --files test/cli/sandbox-status-text.test.ts` passed. - Commit `da9df7334baf0c0d02dabdaf0ea89c4df3be8b06` is GitHub Verified (`reason: valid`). - Docs writer pass found no docs changes needed. --- Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Added coverage for `sandbox <name> status` to verify the reported status output and successful exit behavior. * Confirmed the display includes terminal harness/runtime details and omits unrelated runtime lines. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test for the Deep Agents Code status harness label reported in #5718.
Current main already resolves a registered
langchain-deepagents-codesandbox toLangChain Deep Agents Code (terminal); this locks that user-facing status contract so it cannot regress toOpenClaw (gateway).Related Issue
Fixes #5718
Changes
langchain-deepagents-codesandbox nameddcode-station.Harness: OpenClaw (gateway)orOpenClaw: running.Type of Change
Quality Gates
statusas reporting the terminal runtime plus interactive/headless command shapes.Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Verification detail:
npx vitest run test/cli/sandbox-status-text.test.ts --project clipassed (7 tests).npm run typecheck:clipassed.SKIP=test-cli npx prek run --files test/cli/sandbox-status-text.test.tspassed.da9df7334baf0c0d02dabdaf0ea89c4df3be8b06is GitHub Verified (reason: valid).Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
sandbox <name> statusto verify the reported status output and successful exit behavior.