Repository navigation
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughHosted inference staging now rewrites compatible environment values and readiness checks use a reachability probe. Deep Agents startup now conditionally ensures ChangesHosted inference routing and probes
Deep Agents startup check
Session JSON parsing
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
Contributor
PR Review Advisor — Changes requestedMerge posture: Do not merge yet Action checklist
Findings index
Review findings by urgency: 0 required fixes, 8 items to resolve/justify, 0 in-scope improvements
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/onboard/providers.ts`:
- Around line 260-271: The build-selection staging path in providers.ts is
overriding an explicit COMPATIBLE_API_KEY with sourceKey because
hostedCompatibleBuildSelection now routes into the same write branch as implicit
cases. Update the staging logic around shouldStage and the subsequent write
branch in the provider-selection flow so that when compatibleKey is already
present, the code preserves that explicit credential instead of assigning
sourceKey; keep the existing precedence behavior tied to compatibleKey and only
populate sourceKey for implicit or non-compatible cases.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9030e8ed-f7b3-47e8-b49e-13f24a04bd1d
📒 Files selected for processing (11)
src/lib/onboard/providers.test.tssrc/lib/onboard/providers.tstest/deepagents-code-tui-startup-check.test.tstest/e2e-scenario/fixtures/redaction.tstest/e2e-scenario/live/hermes-e2e.test.tstest/e2e-scenario/live/model-router-provider-routed-inference.test.tstest/e2e-scenario/live/sandbox-survival.test.tstest/e2e-scenario/live/sessions-agents-cli.test.tstest/e2e-scenario/support-tests/hosted-inference.test.tstest/e2e/e2e-cloud-experimental/checks/10-deepagents-code-tui-startup.shtest/e2e/test-sessions-agents-cli.sh
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
PR Review Advisor (Nemotron Ultra) — InformationalMerge posture: Informational / low confidence Action checklist
Findings index
Review findings by urgency: 0 required fixes, 1 item to resolve/justify, 0 in-scope improvements
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Collaborator
Author
|
Superseded by #5887 because force-push is disabled on PR branches and the replacement branch has a clean conventional commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the first release-gate E2E failures found while running the v0.0.69 full nightly candidate: hosted-compatible CI onboarding now overrides explicit cloud selection, Deep Agents TUI checks skip non-Deep-Agents sandboxes before requiring
expect, and JSON/live reachability probes tolerate CI warning and endpoint behavior.Changes
NEMOCLAW_E2E_USE_HOSTED_INFERENCE=1+NEMOCLAW_PROVIDER=cloudthrough the compatible endpoint while keeping normal explicit cloud behavior unchanged.expect./v1/modelspreflights in live Vitest Hermes/sandbox-survival scenarios.nvapi-*key.Type of Change
Quality Gates
NEMOCLAW_E2E_USE_HOSTED_INFERENCErouting and fixture secret filtering; source credentials remain excluded from default child env.Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Targeted verification run:
npm run build:cli npm test -- --run src/lib/onboard/providers.test.ts test/deepagents-code-tui-startup-check.test.ts test/e2e-scenario/support-tests/hosted-inference.test.ts bash -n test/e2e/e2e-cloud-experimental/checks/10-deepagents-code-tui-startup.sh test/e2e/test-sessions-agents-cli.sh npm run typecheck:cliLocal hooks were attempted but the broad local test hook failed on unrelated environment-sensitive tests (Hermes tempdir mode and sandbox rlimit hook); the focused checks above cover this diff.
Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
expectis available when possible.