Skip to content

refactor(openshell): remove diagnostic SSH transport - #6798

Merged
apurvvkumaria merged 25 commits into
refactor/openshell-grpc-rebuild-probe/aefrom
refactor/openshell-grpc-debug-internals/ae
Jul 20, 2026
Merged

apurvvkumaria merged 25 commits into
refactor/openshell-grpc-rebuild-probe/aefrom
refactor/openshell-grpc-debug-internals/ae

Conversation

@ericksoa

@ericksoa ericksoa commented Jul 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Moves in-sandbox debug and diagnostic reads from SSH to the supported OpenShell control boundary.

This is PR 6 of 21 in the OpenShell gRPC migration stack.

Changes

  • Route diagnostic commands through read-only gRPC control.
  • Preserve bounded output and best-effort diagnostic behavior.
  • Remove diagnostic SSH argument construction.

Stack

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs not applicable — justification: this slice changes only internal transport implementation or tests.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: transport-boundary self-review completed; mutations select one transport before dispatch and are never replayed automatically.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — debug command and diagnostic collection tests passed
  • Applicable broad gate passed — targeted and changed-graph tests were used; CI will run the repository-required broad gates
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only) — not applicable
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@ericksoa ericksoa mentioned this pull request Jul 13, 2026
10 of 20 tasks
@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5dfe4042-140f-4ec8-ab22-0b84ee519530

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/openshell-grpc-debug-internals/ae

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the refactor/openshell-g... branch.

TypeScript / code-coverage/cli

The overall coverage in the refactor/openshell-g... branch remains at 79%, unchanged from the refactor/openshell-g... branch.

Show a code coverage summary of the most impacted files.
File refactor/openshell-g... 20130dd refactor/openshell-g... 57b096e +/-
src/lib/cli/logger.ts 91% 85% -6%
src/lib/state/o...config-merge.ts 96% 93% -3%
src/lib/policy/index.ts 65% 64% -1%
src/lib/adapter...shell/client.ts 83% 87% +4%
src/lib/policy/...ateway-state.ts 56% 69% +13%
src/lib/diagnostics/debug.ts 14% 29% +15%
src/lib/adapter...dbox-control.ts 0% 72% +72%
src/lib/adapter...teway-config.ts 0% 78% +78%
src/lib/adapter...dbox-control.ts 0% 91% +91%
src/lib/adapter...trol-routing.ts 0% 94% +94%

Updated July 14, 2026 17:44 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

github-actions Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Advisor assessment: Informational / medium confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

  • GPT-5.6 Terra (primary): Completed · medium confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: diagnostics

1 optional E2E recommendation
  • sandbox-operations

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

ericksoa added 24 commits July 13, 2026 16:18
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

# Conflicts:
#	test/legacy-sandbox-transports.test.ts
…/openshell-grpc-debug-internals/ae

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@wscurran wscurran added area: observability Logging, metrics, tracing, diagnostics, or debug output area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery refactor PR restructures code without intended behavior change labels Jul 14, 2026
@apurvvkumaria apurvvkumaria self-assigned this Jul 19, 2026

@apurvvkumaria apurvvkumaria left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 57b096ea3d560dd4e3c15fdbcfa4767b25ac38b0 against exact stacked base 39ce3ec491f29c0eedf0844e4836c410b3eb548c (#6797). The slice removes temporary SSH configuration and routes only fixed, read-only diagnostic probes through the reviewed gRPC-to-CLI fallback boundary. Sandbox and gateway identifiers remain argument/data fields rather than shell text; partial output, routing errors, and gateway-resolution errors are redacted before terminal or artifact emission; collection remains best-effort; and the async CLI boundary now propagates failures correctly. No credential, injection, authorization, replay, or sandbox-boundary blocker found. All current CI, security scans, advisors, and selected E2E are green; DCO and GitHub verification are valid.

@apurvvkumaria
apurvvkumaria merged commit cf6f1a0 into refactor/openshell-grpc-rebuild-probe/ae Jul 20, 2026
53 of 54 checks passed
@apurvvkumaria
apurvvkumaria deleted the refactor/openshell-grpc-debug-internals/ae branch July 20, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: observability Logging, metrics, tracing, diagnostics, or debug output area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery refactor PR restructures code without intended behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants