[ericksoa]

Summary

Uses one binary-safe CLI capture path for both text and archive fallback execution.

This is PR 15 of 21 in the OpenShell gRPC migration stack.

Changes

• Decode UTF-8 responses from the existing binary-safe CLI capture primitive.
• Remove the duplicate text-capture normalization path.
• Preserve raw stdout bytes only when the caller requests buffer output.
• Delete the unused CLI control singleton.

This slice removes 60 lines and adds 37.

Stack

• Stack index: refactor(openshell): establish sandbox control boundary #6790
• Depends on: refactor(openshell): collapse SSHFS compatibility wrapper #6808
• Review this PR against base branch refactor/openshell-collapse-sshfs-compat/ae to see only this slice.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Existing tests cover changed behavior — justification: CLI control, routing, and direct gRPC adapter suites cover text, binary, failure, and fallback behavior.
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs not applicable — justification: this slice changes only internal transport implementation and tests.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: transport-boundary self-review completed; mutation routing and no-replay behavior are unchanged.
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

• PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — build plus 30 CLI control, routing, and gRPC adapter tests passed
• Applicable broad gate passed — npm run check:diff passed at 64e5e672
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only) — not applicable
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Aaron Erickson aerickson@nvidia.com

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 97a5a00a-04b2-4ff3-a3db-d31e42409cf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/openshell-unify-cli-exec/ae

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the refactor/openshell-c... branch.

TypeScript / code-coverage/cli

The overall coverage in the refactor/openshell-u... branch remains at 79%, unchanged from the refactor/openshell-c... branch.

Show a code coverage summary of the most impacted files.

File	refactor/openshell-c... 5b67372	refactor/openshell-u... 7a3d3ff	+/-
src/lib/onboard...tup-nim-vllm.ts	89%	71%	-18%
src/lib/state/o...config-merge.ts	96%	90%	-6%
src/lib/onboard.ts	30%	29%	-1%
src/lib/diagnostics/debug.ts	14%	29%	+15%
src/lib/adapter...teway-config.ts	0%	77%	+77%
src/lib/adapter...dbox-control.ts	0%	78%	+78%
src/lib/state/s...tore-payload.ts	0%	83%	+83%
src/lib/adapter...dbox-control.ts	0%	94%	+94%
src/lib/adapter...trol-routing.ts	0%	97%	+97%
src/lib/adapter...ndbox-upload.ts	0%	99%	+99%

---

_{Updated July 15, 2026 05:42 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

[github-actions]

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 2 warnings · 1 suggestion
• Model comparison: normalized findings differ; normalized E2E selections differ; Nemotron reported the same number of blockers, 2 more warnings, 1 more suggestion.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: onboard-repair, onboard-resume, state-backup-restore, upgrade-stale-sandbox

3 optional E2E recommendations

• snapshot-commands
• sandbox-operations
• openshell-gateway-auth-contract

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

[apurvvkumaria]

Reviewed exact stacked head 7a3d3ff against base 6a9dce5. The unified capture path preserves binary stdout and bounded combined output, direct gRPC descriptor reads validate stable id/name/image and close clients, read-only fallback remains pre-dispatch only, and snapshot restore rechecks the live image before any destination deletion. Local CLI build and 134 focused gRPC/routing/snapshot tests pass. All 11 commits are GitHub Verified, all repository CI and protected E2E checks are green, and there are no unresolved review or advisor findings.