Repository navigation
test(conformance): port the credential gating e2e tests #5318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewgrossman
wants to merge
17
commits into
main
Choose a base branch
from
test/5296-credential-gating-pilot/matthewgrossman
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,286
−1,244
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3ae3108
feat(testkit): create a sandbox with a policy, an image, and providers
matthewgrossman 7d8a7e7
test(conformance): port the credential gating e2e tests
matthewgrossman 15fd553
test(e2e): provide the Python test image to host-lane conformance
matthewgrossman 38842bb
test(e2e): remove the credential gating tests ported to conformance
matthewgrossman 7a70c12
test(testkit): add policy helpers, provider install, and YAML files
matthewgrossman f0d5287
test(support): add host servers that record what sandboxes send
matthewgrossman 566b39d
test(conformance): build credential gating on shared test support
matthewgrossman 99bbed4
fix(e2e): pass the host gateway IP to the external Kubernetes driver
matthewgrossman 61504a3
test(testkit): default python_image() to a public pinned image
matthewgrossman 3a31220
test(conformance): tighten credential gating checks from review
matthewgrossman 9ab1be1
test(testkit): restore openshell/e2e-python:dev as the default test i…
matthewgrossman 4ff621b
test(conformance): add a positive control to the WebSocket denial test
matthewgrossman e5e72bf
docs(testing): link the remote-cluster follow-up for credential gating
matthewgrossman eb3561b
refactor(test-support): derive the WebSocket accept key with tungstenite
matthewgrossman d246355
fix(e2e): fail the external-driver render when the host gateway alias…
matthewgrossman e22087f
test(testkit): split provider install into profile import and provide…
matthewgrossman aeec397
Merge remote-tracking branch 'origin/main' into test/5296-credential-…
matthewgrossman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
e2e/helm-plugins/openshell-external-compute-driver/host-gateway/driver-env-patch.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| apiVersion: apps/v1 | ||
| kind: StatefulSet | ||
| metadata: | ||
| name: openshell | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: kubernetes-compute-driver | ||
| env: | ||
| - name: OPENSHELL_HOST_GATEWAY_IP | ||
| value: replaced-by-kustomize |
30 changes: 30 additions & 0 deletions
30
e2e/helm-plugins/openshell-external-compute-driver/host-gateway/kustomization.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # The in-process driver reads server.hostGatewayIP from the rendered gateway | ||
| # TOML. The external driver reads it from its own environment, so copy the | ||
| # chart's rendered value into that container. | ||
| apiVersion: kustomize.config.k8s.io/v1alpha1 | ||
| kind: Component | ||
| patches: | ||
| - path: driver-env-patch.yaml | ||
| target: | ||
| group: apps | ||
| version: v1 | ||
| kind: StatefulSet | ||
| name: openshell | ||
| replacements: | ||
| - source: | ||
| group: apps | ||
| version: v1 | ||
| kind: StatefulSet | ||
| name: openshell | ||
| fieldPath: spec.template.spec.hostAliases.0.ip | ||
| targets: | ||
| - select: | ||
| group: apps | ||
| version: v1 | ||
| kind: StatefulSet | ||
| name: openshell | ||
| fieldPaths: | ||
| - spec.template.spec.containers.[name=kubernetes-compute-driver].env.[name=OPENSHELL_HOST_GATEWAY_IP].value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking, fine as a follow-up
Before this PR,
e2e:kuberneteswithe2e,e2e-kubernetesexcluded the host-dependent credential tests. With this PR,openshell-conformanceruns them unconditionally, so a remote Kubernetes or OpenShift gateway fails with connection errors even when it meets the contract. The compatibility bot flagged the same thing.This is acceptable for the pilot if it is tracked. Please link a follow-up issue and say here that these tests need the gateway to reach
host.openshell.internal. The options for the follow-up are to preserve thehost-gatewayopt-in, move these tests to a feature suite, or add an up-front reachability probe that skips with a clear message instead of a 10s poll timeout.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked in #5409, under #5281, with the three options you listed (keep an opt-in, move the tests to a feature suite, or check reachability up front and skip with a clear message).
TESTING.mdand the conformance README now say these tests need sandboxes to reach the test machine ashost.openshell.internaland link the issue.