Repository navigation
Conversation
Signed-off-by: Shiju <shiju@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
|
Label |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
elezar
left a comment
There was a problem hiding this comment.
Maybe a naive question: Should this be handled at a driver level, or should this be exposed as a driver capability for a gateway to check?
|
I think driver-side validation is the right place for this PR’s fix. If we want earlier gateway checks, we could add a driver preflight API as a follow-up. The driver needs to incorporate requirements from operator-installed extensions before it can resolve the backend and validate the final launch plan. |
Summary
Resolve VM requirements against the selected backend's capabilities and allow CPU-only QEMU launches with external kernels. Keep PCI/GPU assignment separate, reject unsupported host/kernel/transport inputs before compute starts, and preserve the assigned GPU through before-launch hooks.
Related Issue
Closes #5372
Prerequisite: #5376, which fixes #5373. This branch includes that patch so the new direct-kernel path has the required guest bootstrap setup. Merge the fd-link fix first.
Changes
Release Notes
Testing
All 282 VM crate library tests passed on macOS, along with scoped all-targets Clippy and formatting. Three targeted mutations restored the old CPU/GPU restrictions or disabled the GPU-hook guard; each matching regression failed as expected. Tests cover CPU-only kernel selection and QEMU arguments, explicit conflicts, invalid kernel headers, both launcher modes, unsupported hosts and post-hook GPU assignment.
Fern docs and navigation checks passed with three warnings in unchanged gateway MDX, remote redirect access and theme contrast. The prerequisite fd patch passed its seven-case Linux namespace regression and fresh Firecracker/libkrun Ready/exec integration checks. Actual CPU-only QEMU Ready on Linux x86_64/KVM has not been tested on this Mac.
Checklist