Repository navigation
chore(server): remove unused registration hooks - #5382
Merged
Merged
Conversation
The method was a compatibility no-op that nothing read. Drop it, its first-party registration calls, and the test helper parameter that only existed for it. Signed-off-by: Evan Lezar <elezar@nvidia.com>
…ion hook The deprecated no-op had no callers. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
changed the title
|
Label |
drew
approved these changes
Nov 9, 2026
elezar
added
area:platform
and removed
area:gateway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove two dead
ComputeDriverRegistrationhooks:with_local_singleplayer()and the deprecatedwith_inherited_config_keys(). Both returnselfand nothing reads them.Related Issue
Closes #5381
Changes
with_local_singleplayerfromopenshell-server, its calls in the Podman, Docker, VM and MXC registrations inopenshell-gateway, and thesingleplayerparameter of thetest_registryhelper inopenshell-server/src/cli.rs.with_inherited_config_keys, which had no callers anywhere in the repo.Testing
cargo fmtforopenshell-serverandopenshell-gatewaycargo clippy -p openshell-server -p openshell-gateway --all-targets -- -D warningspasses (compiles the test targets)cargo test -p openshell-serverfails to link here (library 'z3' not found); relying on CIcfg(windows)and was not compiled locallyChecklist