Repository navigation
Conversation
…5399) Create the per-sandbox broadcast channel on first subscribe instead of first publish, and store events as Arc<CursoredEvent> shared by the channel ring and the replay tail. An unwatched sandbox no longer holds two pre-allocated 1024-slot rings sized for the full Sandbox payload. Signed-off-by: divesh <dgude@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-sandbox log/event buffers no longer pre-allocate ~3.4 MiB per sandbox. The broadcast channel is created on first subscribe, and events are shared between the channel and the replay tail via
Arc.Related Issue
Closes #5399
Changes
PerSandbox.senderis created on firstsubscribe, not on first publish.Arc<CursoredEvent>instead of full copies.WatchSandboxunwraps received events withArc::unwrap_or_clone.Release Notes
Gateway memory no longer grows by several MiB per sandbox that nobody is watching.
Testing
openshell-serverfmt, clippy, and unit tests passTwo create/delete cycles of 20 sandboxes on a single-replica Kubernetes gateway (RSS):
Checklist