Repository navigation
fix(cli): use a POSIX path probe in sandbox download - #5420
Merged
TaylorMutch merged 1 commit intoNov 10, 2026
Merged
TaylorMutch merged 1 commit into
TaylorMutch merged 1 commit into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@TaylorMutch @elezar PTAL, and could one of you triage #4909 so the issue check can pass? Thank you! |
Collaborator
|
/ok to test 44dd9cd |
TaylorMutch
approved these changes
Nov 10, 2026
TaylorMutch
left a comment
TaylorMutch
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the path-probe change and verified that canonicalization and workspace-boundary validation remain intact. All three file-transfer conformance E2E tests passed locally on Alpine (BusyBox 1.37) and Ubuntu 24.04, using Docker bridge mode. Required CI checks pass for this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox downloadworks on busybox images.Related Issue
Closes #4909
Changes
[ -e ]and barerealpathinstead ofrealpath -e --../so leading dashes stay safe.Testing
Checklist