Repository navigation
test(e2e): join shared-supervisor-ha helm overlays without image-tag syntax - #5447
Open
ChristianZaccaria wants to merge 1 commit into
Open
ChristianZaccaria wants to merge 1 commit into
ChristianZaccaria wants to merge 1 commit into
Conversation
…syntax Signed-off-by: ChristianZaccaria <christian.zaccaria.cz@gmail.com>
Contributor
Author
|
I cannot add labels on this repo. Could someone please add |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5448
Summary
The e2e:kubernetes:shared-supervisor-ha task colon-joins three Helm values files in one string:
…/values-high-availability.yaml:deploy/helm/…/values-supervisor-ha.yaml:deploy/…
Anything that scans for container images (grep, image-policy linters, Trivy-style tag checks) reads the middle join as
helm/openshell/ci/values-supervisor-ha.yaml:deploy. That is a path list, not an image. Splitting the join across assignments keeps the same OPENSHELL_E2E_KUBE_EXTRA_VALUES contract and --values order, and it scales if a fourth overlay is added.Changes
tasks/test.toml.OPENSHELL_E2E_KUBE_EXTRA_VALUESvalue and caller-overlay append.Testing
Verified
tasks/test.tomlstill parses andmisestill listse2e:kubernetes:shared-supervisor-ha.Checklist