Repository navigation
Conversation
Signed-off-by: Adrien Langou <alangou@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-5451.docs.buildwithfern.com/openshell |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sign published OpenShell OCI images and Helm charts with cosign using the publishing workflow's GitHub Actions OIDC identity. The change adds signing to the existing publication jobs without a signing-key secret or a new workflow.
Related Issue
None.
Changes
gateway,sandbox,supervisor,helm-chart, andopenshell-workspaceby manifest digest for stable, prerelease, and dev publications, including both dev chart versions.cosign-installerto v4.1.3, which installs cosign v3.1.4. Grantid-token: writeto the two signing jobs and reuse their GHCR login. Lookup and signing failures fail the job; retries also sign retained artifacts.Release Notes
Published runtime images and OCI Helm charts can be verified with cosign 3 using the OpenShell release workflow's identity.
Testing
uv run --no-project --with pytest --with pyyaml pytest tasks/scripts/oci_signing_test.py.Fern reports zero errors and three existing warnings concerning an unrelated gateway configuration page, an unauthenticated redirects check, and theme contrast.
Checklist