Repository navigation
Conversation
The program wrote junit.xml only after its last test, so a run-level timeout lost the report. Rewrite it after each test, replacing the file in one step so a kill mid-write leaves the previous report. Part of #5416. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5455, which is stacked on #5450. This diff is against #5455's branch.
Summary
The testkit program wrote
junit.xmlonly after its last test, so a run-level timeout (45 minutes) lost the report and only the log survived.<path>.partialand rename, so a kill during a write leaves the previous report, not a truncated one.The test that is running when the run is stopped is not in the report, since it has no result yet.
Related Issue
Part of #5416 (this item came from the review of #5332; the issue stays open). Also resolves the
junit.xmlnote on #5333.Testing
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass fortests/testkit.