Repository navigation
feat(helm): separate metrics enablement from listener port - #5478
Merged
TaylorMutch merged 2 commits intoNov 11, 2026
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-5478.docs.buildwithfern.com/openshell |
TaylorMutch
marked this pull request as ready for review
November 10, 2026 23:53
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. helm — No explicit risk acceptance foundservice.metricsPort: 0 previously disabled metrics but now fails chart validation, even with metrics.enabled=false.
Review details
Advisory review; publication gates are unchanged. |
matthewgrossman
approved these changes
Nov 11, 2026
Collaborator
Author
|
This fixes unclear behavior in the metrics port enablement so compatibility is not a concern. |
TaylorMutch
deleted the
feat/5474-separate-metrics-enablement/TaylorMutch
branch
November 11, 2026 00:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
metrics.enabledto enable or disable the gateway's dedicated Prometheus endpoint independently of its port. Metrics remain enabled on port 9090 by default; disabling the endpoint retains the configured port and omits the runtime listener, container port, and Service port.Related Issue
Closes #5474.
Changes
metrics.enabled, defaulting to true, and use it consistently across runtime and Kubernetes resources.service.metricsPortbetween 1 and 65535; check listener collisions only while metrics are enabled.metricsPort: 0andfalsevalues with instructions to setmetrics.enabled=falseand retain a valid port. Requesting metrics TLS while disabled also fails rendering.Testing
mise run helm:test: 470 gateway and 7 workspace chart tests, generated gateway TOML validation through the Rust loader, and resource coherence checksChecklist