Repository navigation
fix(deps): update rustix and refresh the RSA advisory exception - #5485
Merged
Merged
Conversation
Update rustix 1.1.4 and 1.1.5 to 1.1.6 in every tracked Cargo lockfile, including aligned test workspaces. This addresses GHSA-jh2m-fhpj-3vr7. Keep unaffected rustix 0.38.44. Precise Cargo updates also rebind existing windows-sys dependency edges within parent constraints; no other package versions change. Signed-off-by: Adrien Langou <alangou@nvidia.com>
RSA 0.10.0 is patched, but released russh versions through 0.65.1 still require 0.10.0-rc.18 and ssh-key 0.7.0-rc.11. Record the parent constraint and removal condition for RUSTSEC-2023-0071. The advisory remains unresolved. Signed-off-by: Adrien Langou <alangou@nvidia.com>
|
Label |
Contributor
Author
|
/ok to test c2c9d1c |
SDAChess
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update rustix to 1.1.6 across all 12 tracked Cargo lockfiles for RUSTSEC-2026-0486, which concerns uninitialized memory in extended-attribute buffer handling. Correct the RSA exception explanation now that a patched release exists but cannot resolve with the published SSH dependencies.
Related Issue
N/A. No covering issue, per user instruction.
Changes
Release Notes
Updates the Rust filesystem dependency for an upstream memory-safety advisory.
Testing
test:e2eis applied. SHA-bound admission created the matching mirror. Branch Checks passed. Branch E2E Checks, attempt 1 is running the test suites with no failed jobs reported at the latest check; the remote E2E outcome is pending. Review Readiness failed while its automation attempted to request reviewers; its log does not expose the underlying HTTP error. PR Issue Acceptance and DCO passed.All open Dependabot pages were read successfully; there were no open alerts. Baseline root and V8 advisory scans failed for rustix. The final configured scans pass. A diagnostic scan with both exceptions unmasked still reports RSA and SQLite, as expected. Initial test and Clippy attempts exhausted the temporary filesystem; build artifacts were moved to a larger disk-backed cache before rerunning.
Validation used Rust 1.95.0 and cargo-deny 0.20.2 on
c2c9d1cf4edc61142dd5d24b23b1e1cbfae8d269, based on mainf1ce6930710a76a5fac4d423b2c1b318ace3839b. Main was fetched again before publication and remained unchanged. The RustSec database was refreshed on November 11.Earlier parallel sandbox attempts failed two different socket assertions. Both passed in the final standard matrix, and the full sandbox suite passed 307/307. Baseline sandbox runs passed twice; the intermittent failures' cause remains unproven. A diagnostic globally serial run stalled in a subprocess fixture and was stopped. The final run used normal concurrency, included installed
/usr/sbintools on PATH, and used an isolated TMPDIR. Docker conformance initially failed one upload because an unrelated/tmp/.gitmarker interfered with repository discovery; all 22 scenarios passed with isolated temporary storage. No tests were disabled or changed.Checklist