Repository navigation
fix(build): resolve sibling script imports during typechecking - #5490
Merged
Merged
Conversation
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
github-actions
Bot
requested review from
SDAChess,
TaylorMutch and
matthewgrossman
November 11, 2026 15:55
purp
enabled auto-merge
November 11, 2026 16:04
SDAChess
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Python CI typechecking of standalone scripts that import sibling modules. Add
tasks/scriptsto ty's search path in the sharedpython:typechecktask so local and CI runs use the same module resolution.Related Issue
No issue: build-fix exception for an author with verified repository write access. The first Branch Checks attempt on #5260 failed on both Linux architectures because
check_review_readiness.pycould not resolvecheck_maintainer_approvalorlabel_accepted_work.Changes
--extra-search-path tasks/scriptsto the existing ty invocation; keep all diagnostics enabled.Release Notes
Testing
mise run python:typecheckpasses across the configured Python paths, including its protobuf-generation dependency.mise run validateandgit diff --checkpass.Checklist