Skip to content

fix(build): resolve sibling script imports during typechecking - #5490

Merged
purp merged 1 commit into
NVIDIA:mainfrom
purp:fix/python-typecheck-imports/purp
Nov 11, 2026
Merged

purp merged 1 commit into
NVIDIA:mainfrom
purp:fix/python-typecheck-imports/purp

Conversation

@purp

@purp purp commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix Python CI typechecking of standalone scripts that import sibling modules. Add tasks/scripts to ty's search path in the shared python:typecheck task so local and CI runs use the same module resolution.

Related Issue

No issue: build-fix exception for an author with verified repository write access. The first Branch Checks attempt on #5260 failed on both Linux architectures because check_review_readiness.py could not resolve check_maintainer_approval or label_accepted_work.

Changes

  • Add --extra-search-path tasks/scripts to the existing ty invocation; keep all diagnostics enabled.

Release Notes

Testing

  • mise run python:typecheck passes across the configured Python paths, including its protobuf-generation dependency.
  • Reproduced both unresolved-import errors against feat(review): automatically label new PRs for accepted work #5260's scripts without the flag; the same scripts and tests typecheck successfully with the flag.
  • mise run validate and git diff --check pass.
  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (configuration-only fix; verified with the actual typechecker)
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp purp added the area:build Related to CI/CD and builds label Nov 11, 2026
@purp
purp enabled auto-merge November 11, 2026 16:04
@purp
purp added this pull request to the merge queue Nov 11, 2026
Merged via the queue into NVIDIA:main with commit e3edb84 Nov 11, 2026
94 of 95 checks passed
@purp
purp deleted the fix/python-typecheck-imports/purp branch November 11, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Related to CI/CD and builds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants