Repository navigation
Fix spherical harmonics basis normalization - #499
Open
deepanshupal wants to merge 3 commits into
Open
deepanshupal wants to merge 3 commits into
deepanshupal wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #483.
M_1_SQRTPIis1 / sqrt(pi), but all 16 real SH basis functions use it in their denominator. This scales each basis value by pi instead of using the documented orthonormal basis. For example, Y00 is about 0.8862269 rather than 0.2820948.Replace the denominators with
M_SQRTPI. Add a Falcor GPU regression test for Y00 and the degree-0 through degree-3 addition theorem on the three coordinate axes and normalized (1, 2, 3).Validation:
Limits: the GPU test was added and its Slang shader compiled, but it was not executed on a GPU. The Falcor C++ test runner and full Falcor suite were not built or run in this environment. The executable red/green evidence above is official-Slang CPU execution, not a GPU test pass.