Skip to content

Add offline regression coverage for validate_docs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
1nfernet wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add offline regression coverage for validate_docs #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/test_validate_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,24 @@ def test_allows_confirmed_decorative_image(self) -> None:
self.assertEqual(errors, [])


class IsExternalTests(unittest.TestCase):
def test_recognizes_supported_schemes_case_insensitively(self) -> None:
for target in ("HTTP://example.test", "MailTo:team@example.test", "DATA:text/plain,ok"):
with self.subTest(target=target):
self.assertTrue(validate_docs.is_external(target))

def test_rejects_empty_unicode_and_nearby_non_external_targets(self) -> None:
for target in ("", " https://example.test", "https:", "ftp://example.test", "https：//example.test"):
with self.subTest(target=target):
self.assertFalse(validate_docs.is_external(target))

def test_non_string_targets_raise_type_specific_errors(self) -> None:
cases = ((None, AttributeError), (b"https://example.test", TypeError))
for target, error in cases:
with self.subTest(target=target):
with self.assertRaises(error):
validate_docs.is_external(target) # type: ignore[arg-type]


if __name__ == "__main__":
unittest.main()