Repository navigation
Conversation
Tapping an image in a direct-message or org thread now opens the image viewer from #175 at that image. It pages through that message's images only, as a commit's do. Drag to close and Save to Photos come with it. Images of a message still being pushed stay untappable, since they only exist on the phone until devnull has them. The long-press menu on a message's images is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #175. Base is
feat/picture-viewer, so this diff only shows the Remotes part. Merge #175 first.Tapping an image in a Remotes thread now opens the full-screen viewer from #175 at that image. Swipe to page, drag up or down to close, and Save to Photos all come with it, since
Conversationjust uses theShowsImageViewertrait and includes theimage-viewerpartial once. Before this, tapping an image did nothing.The viewer pages through the tapped message's images only, not every image in the conversation. That matches how a commit's images work. It also keeps the dashes at the bottom usable: they are 22pt each, so a thread with 20 images would run them off the screen. And a whole-thread viewer would have to change under you as older messages load and new ones arrive. Easy to revisit if paging the whole thread turns out to be what people want.
Things to know:
Tested on an iOS 27.0 simulator and an Android 35 emulator against a local API with a DM holding two image messages (three images with no text, two with text). On both: tap opens at the tapped image, paging stays within that message, Save landed in Photos (iOS) and Pictures/devnull (Android) with the toast, and dragging down closes it. Long press on the images still opened Reply, React and Copy text on iOS.
php artisan test: 1911 passed, with new tests inConversationTestand an extra check inRemotesComposerTestfor pending images.Screenshots
The viewer shots show the second of three images from one message. Recording: iOS light, open, page and drag to close
🤖 Generated with Claude Code