Skip to content

Profile picture viewer, bio tags like the web, org share in the nav bar, glass Follow - #181

Draft
simonhamp wants to merge 1 commit into
feat/picture-viewerfrom
feat/profile-polish
Draft

simonhamp wants to merge 1 commit into
feat/picture-viewerfrom
feat/profile-polish

Conversation

@simonhamp

Copy link
Copy Markdown
Member

Depends on #175 and is based on its branch (feat/picture-viewer), because the profile picture opens in that viewer. Merge #175 first, then retarget this to main.

Four changes to the profile and organization screens:

Profile picture. On a person's profile, tapping the avatar opens it full-screen in the #175 viewer, where it can be zoomed and saved to Photos. It asks GitHub for s=1024, which is what the web's ProfilePicture uses. GitHub never sends more than the size the picture was uploaded at, so many avatars still come back at 460 pixels. A live avatar still opens the stream, and organization avatars don't open. The web rounds the picture in its viewer; here it shows square, because the viewer draws the image to fit the screen and EDGE can't round just the drawn part.

Tags in a bio. Accounts tagged in a bio or company (@laravel) are now drawn like the web's BioText: the account's square GitHub icon (github.com/{handle}.png) and its handle in a small tag. EDGE can't put an image inside a run of text, so a bio with tags is drawn as a wrapping row of words and tags. A bio without tags is still one run of text. Organization pages draw their bio tags the same way but still open them on GitHub, as the web's organization page does.

A tag opens the app's own screen when devnull has a page for that handle, using the bio_profiles map the users API already returns. Anything else opens on GitHub, as on the web. The API doesn't say whether a handle is a user or an organization, so the app opens it as a user and the profile screen hands over to the organization screen when the user lookup 404s (existing behaviour in Profile::refused()). That costs one wasted request and a moment of the loading state.

API change that would remove the hop: in Api\UserController::show, send the type next to bio_profiles, for example

"bio_profile_types": { "laravel": "organization", "eveline24": "user", "taylor": "unclaimed" }

built from profiles.type plus whether a user row exists. The app already reads this field if it's there: organizations open the organization screen directly, and unclaimed developers go to GitHub, since the app has no unclaimed-profile screen (today they would hop to the organization screen and fail).

Organization share. Share moved out of the header into its own nav bar button, with the same icons as Share profile (Lucide share on iOS, share-2 on Android).

Follow buttons. Follow, Unfollow and Remote are 40pt pills instead of small theme buttons. On iOS they sit on Liquid Glass (ios:glass:interactive), the way the sheet bar buttons and the #177 composer do. Follow is your colour seen through the glass. Android keeps solid pills, since EDGE has no glass there. native:button drops background classes, so this is a pressable in a new glass-pill-button partial. "Edit on GitHub" on your own profile is unchanged.

Things to check

Tests

1,916 tests pass, run serially. New tests cover the tag layout and where each kind of tag opens, the 1024 avatar URL and the viewer, the nav bar share, and the pill colours and glass. Tests that looked for follow as a button now look for a pressable.

Tested on an iPhone 18 Pro simulator (iOS 27.0) and an Android 35 emulator against a local API seeded with a bio that tags @laravel, @dev-null-sh, @nativephp and @local-dev: tapped the avatar, saved it to Photos (checked in the photo library on both), tapped the @laravel tag to reach the organization, shared from the organization nav bar, and followed and unfollowed both a person and the organization, in light and dark.

Screenshots

The web for comparison (local API, signed out; headless Chrome cut the right edge off):

organization

iOS light iOS dark Android light Android dark
Before
After

organization-follow

iOS light iOS dark Android light Android dark
After

organization-share

iOS light iOS dark Android light Android dark
After

profile

iOS light iOS dark Android light Android dark
Before
After

profile-follow

iOS light iOS dark Android light Android dark
After

profile-picture

iOS light iOS dark Android light Android dark
After
  • No visible change

🤖 Generated with Claude Code

Tapping the avatar on a person's profile now opens their picture in the
full-screen image viewer from #175, where it can be zoomed and saved.
It asks GitHub for the 1024 pixel version, as the web does. A live
avatar still opens the stream.

Accounts tagged in a bio or company (like @laravel) are drawn as the
web draws them: the account's square GitHub icon and its handle in a
small tag. EDGE can't put an image inside a run of text, so a bio with
tags is laid out as a wrapping row of words and tags. A tag opens the
account in the app when devnull has a page for it (the API's
bio_profiles), and GitHub otherwise. devnull doesn't say whether that
page is a user or an organization, so it opens as a user and the
profile hands over to the organization screen on a 404, as it already
did. If the API starts sending bio_profile_types, the app uses it.

An organization's Share moves out of the header into its own nav bar
button.

Follow, Unfollow and Remote are now 40pt pills on Liquid Glass on iOS.
Follow is tinted with your colour through the glass. Android keeps a
solid pill.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant