Skip to content

Only read --watch and udid where the command has them - #680

Open
simonhamp wants to merge 1 commit into
mainfrom
fix/runs-android-options
Open

simonhamp wants to merge 1 commit into
mainfrom
fix/runs-android-options

Conversation

@simonhamp

Copy link
Copy Markdown
Member

native:package uses the RunsAndroid trait but has no --watch option or udid argument. The trait read both anyway, which throws at runtime on that command and gives three PHPStan errors on main.

This checks for the option and argument before reading them. native:run behaves as before.

I found it while working on the Asgard branch (#665) and split it out so it can land on its own.

🤖 Generated with Claude Code

native:package shares RunsAndroid but has no --watch option or udid
argument, so PHPStan flags the reads on main. Guard them the way the
trait already guards --fresh. No change for native:run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant