Repository navigation
Require nativephp/mobile ^4.8 - #213
Merged
Merged
Conversation
main now renders attributes that only 4.8.0 sends: the gesture area's trigger-x / trigger-y and @trigger (mobile-air #651, used by #197) and text's min-scale (mobile-air #667, used by #206). Against 4.7 those props never arrive, so the features silently do nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mobile-air 4.8.0 is out, and the next mobile-ui release needs it. Two features already merged here only work with attributes that core started sending in 4.8.0:
trigger-x/trigger-yand@triggerfrom Let a gesture area's pan trigger when let go far enough mobile-air#651min-scale) renders themin_scaleprop from Let text shrink to fit its lines with min-scale mobile-air#667On 4.7 those props never reach the renderers, so both features do nothing without any error. Raising the floor to ^4.8 means anyone who gets the new release also gets a core that drives them.
The only change is the constraint in composer.json. I ran
composer update nativephp/mobilelocally, which resolved to 4.8.0, and the full suite passes against it (502 tests). Unlike the 4.7 bump, the tests needed no changes.🤖 Generated with Claude Code