[REVIEW #1913 FIRST] Determine auto-join by server's bot quota mode convar#1935
Closed
nullsystem wants to merge 3 commits intoNeotokyoRebuild:masterfrom
Closed
[REVIEW #1913 FIRST] Determine auto-join by server's bot quota mode convar#1935nullsystem wants to merge 3 commits intoNeotokyoRebuild:masterfrom
nullsystem wants to merge 3 commits intoNeotokyoRebuild:masterfrom
Conversation
On entering a server, a ping-reply is now sent to the server to get the most up to date players count upon entering. Auto-join is determined if the server's full when trying to enter, and if so enters an auto-join state where it'll refresh for 15s checking count then entering when there's a free slot available. The auto-join popup bar stays on any states. * fixes NeotokyoRebuild#1298
Now with passworded server auto-join, it'll prompt first and save the password rather than only prompting on joining in.
By default, server's kicks out bot due to fill behavior and so doesn't need to check bot count. However if the server's using normal or match, then the server returns relevant tags and the client will include bot count in auto-join player count decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVIEW #1913 FIRST
Description
By default, server's kicks out bot due to fill behavior and so doesn't need to check bot count. However if the server's using normal or match, then the server returns relevant tags and the client will include bot count in auto-join player count decision.
Toolchain