Skip to content

Fix TaskExecutorReconnectionIntegrationTest not stop old actors #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellolittlej merged 2 commits into from
May 7, 2026
+9 −14
Merged

Fix TaskExecutorReconnectionIntegrationTest not stop old actors #855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9de9f57
Fix TaskExecutorReconnectionIntegrationTest not stop old actors
May 7, 2026
9474abb
Merge branch 'master' into stop-old-actors-from-test
hellolittlej May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions ...test/java/io/mantisrx/master/resourcecluster/TaskExecutorReconnectionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@
import java.util.concurrent.CompletableFuture;

import lombok.extern.slf4j.Slf4j;
import org.junit.AfterClass;
import org.junit.After;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
import org.mockito.ArgumentCaptor;

Expand All @@ -94,7 +93,7 @@ public class TaskExecutorReconnectionIntegrationTest {
private static final WorkerId WORKER_ID_1 =
WorkerId.fromIdUnsafe("test-job-1-worker-0-1");

private static ActorSystem actorSystem;
private ActorSystem actorSystem;

private final TestingRpcService rpcService = new TestingRpcService();
private final TaskExecutorGateway gateway = mock(TaskExecutorGateway.class);
Expand All @@ -106,19 +105,9 @@ public class TaskExecutorReconnectionIntegrationTest {
private final MantisPropertiesLoader propertiesLoader =
new DefaultMantisPropertiesLoader(System.getProperties());

@BeforeClass
public static void setup() {
actorSystem = ActorSystem.create();
}

@AfterClass
public static void teardown() {
TestKit.shutdownActorSystem(actorSystem);
actorSystem = null;
}

@Before
public void setupTest() throws Exception {
actorSystem = ActorSystem.create();
rpcService.registerGateway(TASK_EXECUTOR_ADDRESS, gateway);

mantisJobStore = mock(MantisJobStore.class);
Expand Down Expand Up @@ -167,6 +156,12 @@ public void setupTest() throws Exception {
new LongDynamicProperty(propertiesLoader, "resourcecluster.gateway.maxConcurrentRequests.test", 100000L));
}

@After
public void teardownTest() {
TestKit.shutdownActorSystem(actorSystem);
actorSystem = null;
}

@Test
public void testJobMessageRouterIntegration() {
// This test verifies that the jobMessageRouter is properly configured
Expand Down
Loading