fix(openvpn-status): manage real_address format after OpenVPN version update#1687
Open
m-dilorenzi wants to merge 2 commits into
Open
fix(openvpn-status): manage real_address format after OpenVPN version update#1687m-dilorenzi wants to merge 2 commits into
m-dilorenzi wants to merge 2 commits into
Conversation
m-dilorenzi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains updates to manage users' connection status for the OpenVPN RoadWarrior server.
After updating the OpenVPN package from 2.6.14 to 2.7.4, the
real_addressfield is now formatted as[proto]:[ip]:[port], which caused an inconsistent state in the OpenVPN RoadWarrior section: a user can appear disconnected even though they are actually connected (a new connection history record is correctly visible in the Connections History table).The parsing logic that extracts the client's
ipand `port' has been updated to handle real_address values with two or three parts. If there are two parts, the behavior remains unchanged; if there are three parts, the first part (the proto information) is ignored.If
real_addresscontains only one part or more than three parts, the entirereal_addressis used as the value to avoid problems (the IP address is shown only in the "More info" tooltip).Closes: #1686