Release 3.0.0 alpha.7

.github/workflows/ci.yml

@@ -1,10 +1,8 @@
 name: CI
 
 on:
-  push:
-    paths-ignore:
-      - '*.md'
   pull_request:
+    types: [opened, synchronize, reopened]
 
 env:
   CI: true
@@ -23,7 +21,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ env.NODE_VER }}
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - run: npm install
       - name: Initialize MySQL
         run: sh sql/init-mysql.sh
@@ -56,12 +54,12 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node-version: ${{ fromJson(needs.get-lts.outputs.active) }}
+        node-version: ${{ fromJson(needs.get-lts.outputs.lts) }}
       fail-fast: false
     steps:
       - run: sudo /etc/init.d/mysql start
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node-version }}
       - run: sh sql/init-mysql.sh
@@ -73,15 +71,15 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        node-version: ${{ fromJson(needs.get-lts.outputs.active) }}
+        node-version: ${{ fromJson(needs.get-lts.outputs.lts) }}
       fail-fast: false
     steps:
       - name: Install & Start MySQL
         run: |
           brew install mysql@8.4
           brew services start mysql@8.4
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         name: Node ${{ matrix.node-version }} on ${{ matrix.os }}
         with:
           node-version: ${{ matrix.node-version }}
@@ -95,15 +93,15 @@ jobs:
     runs-on: windows-latest
     strategy:
       matrix:
-        node-version: ${{ fromJson(needs.get-lts.outputs.active) }}
+        node-version: ${{ fromJson(needs.get-lts.outputs.lts) }}
         experimental: [true]
       fail-fast: false
     steps:
       - name: Install MySQL
         run: |
           choco install mysql
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         name: Node ${{ matrix.node-version }}
         with:
           node-version: ${{ matrix.node-version }}

.github/workflows/publish.yml

@@ -1,25 +1,20 @@
 name: publish
 
 on:
-  push:
-    branches:
-      - main
-    paths:
-      - package.json
-    release:
-      types: [published]
+  release:
+    types: [published]
 
 env:
   CI: true
-  node-version: 20
+  node-version: 22
 
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
       - run: sudo /etc/init.d/mysql start
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: ${{ env.node-version }}
       - run: sh sql/init-mysql.sh
@@ -30,25 +25,19 @@ jobs:
     needs: build
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v6
         name: Node ${{ env.node-version }}
         with:
           node-version: ${{ env.node-version }}
           registry-url: https://registry.npmjs.org/
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0
           # fetch-depth 0 needed by GitHub Release
 
       - name: publish to NPM
         run: npm publish --access=public
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
-
-      - name: GitHub Release
-        uses: justincy/github-action-npm-release@2.0.1
-        id: release
 
   publish-gpr:
     needs: build
@@ -57,8 +46,8 @@ jobs:
       contents: read
       packages: write
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: ${{ env.node-version }}
           registry-url: https://npm.pkg.github.com/

CHANGELOG.md

@@ -1,7 +1,15 @@
+# Changelog
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/).
+
 # CHANGES
 
 ### Unreleased
 
+### [3.0.0-alpha.7] - 2026-03-13
+
+- fixes
+
 ### [3.0.0-alpha.6] - 2025-04-08
 
 - dep(eslint): upgraded to v9
@@ -39,7 +47,11 @@
 - lib/user.get: convert booleans
 
 
+[3.0.0-alpha.0]: https://github.com/NicTool/api/releases/tag/3.0.0-alpha.0
+[3.0.0-alpha.1]: https://github.com/NicTool/api/releases/tag/3.0.0-alpha.1
+[3.0.0-alpha.2]: https://github.com/NicTool/api/releases/tag/3.0.0-alpha.2
 [3.0.0-alpha.3]: https://github.com/NicTool/api/releases/tag/3.0.0-alpha.3
-[3.0.0-alpha.4]: https://github.com/NicTool/api/releases/tag/3.0.0-alpha.4
-[3.0.0-alpha.5]: https://github.com/NicTool/api/releases/tag/3.0.0-alpha.5
-[3.0.0-alpha.6]: https://github.com/NicTool/api/releases/tag/3.0.0-alpha.6
+[3.0.0-alpha.4]: https://github.com/NicTool/api/releases/tag/v3.0.0-alpha.4
+[3.0.0-alpha.5]: https://github.com/NicTool/api/releases/tag/v3.0.0-alpha.5
+[3.0.0-alpha.6]: https://github.com/NicTool/api/releases/tag/v3.0.0-alpha.6
+[3.0.0-alpha.7]: https://github.com/NicTool/api/releases/tag/v3.0.0-alpha.7

CONTRIBUTORS.md

@@ -0,0 +1,9 @@
+# Contributors
+
+This handcrafted artisanal software is brought to you by:
+
+| <img height="80" src="https://avatars.githubusercontent.com/u/261635?v=4"><br><a href="https://github.com/msimerson">msimerson</a> (<a href="https://github.com/NicTool/api/commits?author=msimerson">14</a>)|
+| :---: |
+
+<sub>this file is generated by [.release](https://github.com/msimerson/.release).
+Contribute to this project to get your GitHub profile included here.</sub>

lib/config.js

@@ -12,7 +12,7 @@ class Config {
     this.getEnv(opts)
   }
 
-  async getEnv(opts = {}) {
+  getEnv(opts = {}) {
     this.env = process.env.NODE_ENV ?? opts.env ?? ''
     this.debug = Boolean(process.env.NODE_DEBUG)
     if (this.debug) console.log(`debug: true, env: ${this.env}`)

lib/config.test.js

@@ -39,15 +39,12 @@ describe('config', () => {
 
     it(`detects NODE_DEBUG env`, async () => {
       process.env.NODE_DEBUG = 1
-      let cfg = await Config.get('mysql', 'test')
+      await Config.get('mysql', 'test')
       assert.equal(Config.debug, true)
 
       process.env.NODE_DEBUG = ''
-      cfg = await Config.get('mysql', 'test')
+      await Config.get('mysql', 'test')
       assert.equal(Config.debug, false)
-
-      cfg = await Config.get('mysql', 'test')
-      assert.equal(cfg.user, 'root')
     })
   })
 })

lib/group.js

@@ -15,9 +15,7 @@ class Group {
       if (g.length === 1) return g[0].id
     }
 
-    return await Mysql.execute(
-      ...Mysql.insert(`nt_group`, mapToDbColumn(args, groupDbMap)),
-    )
+    return await Mysql.execute(...Mysql.insert(`nt_group`, mapToDbColumn(args, groupDbMap)))
   }
 
   async get(args) {
@@ -48,11 +46,7 @@ class Group {
     const id = args.id
     delete args.id
     const r = await Mysql.execute(
-      ...Mysql.update(
-        `nt_group`,
-        `nt_group_id=${id}`,
-        mapToDbColumn(args, groupDbMap),
-      ),
+      ...Mysql.update(`nt_group`, `nt_group_id=${id}`, mapToDbColumn(args, groupDbMap)),
     )
     return r.changedRows === 1
   }
@@ -67,9 +61,7 @@ class Group {
   }
 
   async destroy(args) {
-    const r = await Mysql.execute(
-      ...Mysql.delete(`nt_group`, { nt_group_id: args.id }),
-    )
+    const r = await Mysql.execute(...Mysql.delete(`nt_group`, { nt_group_id: args.id }))
     return r.affectedRows === 1
   }
 }

lib/mysql.js

@@ -18,8 +18,7 @@ class Mysql {
     if (_debug) console.log(cfg)
 
     this.dbh = await mysql.createConnection(cfg)
-    if (_debug)
-      console.log(`MySQL connection id ${this.dbh.connection.connectionId}`)
+    if (_debug) console.log(`MySQL connection id ${this.dbh.connection.connectionId}`)
     return this.dbh
   }
 
@@ -54,10 +53,7 @@ class Mysql {
   }
 
   update(table, where, params = {}) {
-    return [
-      `UPDATE ${table} SET ${Object.keys(params).join('=?,')}=? WHERE ${where}`,
-      Object.values(params),
-    ]
+    return [`UPDATE ${table} SET ${Object.keys(params).join('=?,')}=? WHERE ${where}`, Object.values(params)]
   }
 
   delete(table, params) {

lib/mysql.test.js

@@ -34,32 +34,23 @@ describe('mysql', () => {
       first_name: 'uNite',
       last_name: 'Test',
     })
-    assert.deepEqual(r, [
-      `INSERT INTO nt_user (first_name,last_name) VALUES(?,?)`,
-      ['uNite', 'Test'],
-    ])
+    assert.deepEqual(r, [`INSERT INTO nt_user (first_name,last_name) VALUES(?,?)`, ['uNite', 'Test']])
   })
 
   describe('update', () => {
     it('formats with one value', () => {
       const r = Mysql.update(`nt_user`, `nt_user_id=4096`, {
         first_name: 'uNite',
       })
-      assert.deepEqual(r, [
-        `UPDATE nt_user SET first_name=? WHERE nt_user_id=4096`,
-        ['uNite'],
-      ])
+      assert.deepEqual(r, [`UPDATE nt_user SET first_name=? WHERE nt_user_id=4096`, ['uNite']])
     })
 
     it('formats with two values', () => {
       const r = Mysql.update(`nt_user`, `nt_user_id=4096`, {
         last_name: 'Teste',
         is_admin: 1,
       })
-      assert.deepEqual(r, [
-        `UPDATE nt_user SET last_name=?,is_admin=? WHERE nt_user_id=4096`,
-        ['Teste', 1],
-      ])
+      assert.deepEqual(r, [`UPDATE nt_user SET last_name=?,is_admin=? WHERE nt_user_id=4096`, ['Teste', 1]])
     })
 
     it('formats with three values', () => {

lib/nameserver.js

@@ -26,12 +26,7 @@ class Nameserver {
       delete args.export.type
     }
 
-    return await Mysql.execute(
-      ...Mysql.insert(
-        `nt_nameserver`,
-        mapToDbColumn(objectToDb(args), nsDbMap),
-      ),
-    )
+    return await Mysql.execute(...Mysql.insert(`nt_nameserver`, mapToDbColumn(objectToDb(args), nsDbMap)))
   }
 
   async get(args) {
@@ -79,11 +74,7 @@ class Nameserver {
     delete args.id
     // Mysql.debug(1)
     const r = await Mysql.execute(
-      ...Mysql.update(
-        `nt_nameserver`,
-        `nt_nameserver_id=${id}`,
-        mapToDbColumn(args, nsDbMap),
-      ),
+      ...Mysql.update(`nt_nameserver`, `nt_nameserver_id=${id}`, mapToDbColumn(args, nsDbMap)),
     )
     return r.changedRows === 1
   }
@@ -98,9 +89,7 @@ class Nameserver {
   }
 
   async destroy(args) {
-    const r = await Mysql.execute(
-      ...Mysql.delete(`nt_nameserver`, { nt_nameserver_id: args.id }),
-    )
+    const r = await Mysql.execute(...Mysql.delete(`nt_nameserver`, { nt_nameserver_id: args.id }))
     return r.affectedRows === 1
   }
 }
@@ -109,14 +98,7 @@ export default new Nameserver()
 
 function dbToObject(rows) {
   for (const row of rows) {
-    for (const f of [
-      'description',
-      'address6',
-      'remote_login',
-      'datadir',
-      'logdir',
-      'export_status',
-    ]) {
+    for (const f of ['description', 'address6', 'remote_login', 'datadir', 'logdir', 'export_status']) {
       if ([undefined, null].includes(row[f])) row[f] = ''
     }
     for (const f of ['export']) {

lib/nameserver.test.js

@@ -27,9 +27,7 @@ describe('nameserver', function () {
   })
 
   it('changes a nameserver', async () => {
-    assert.ok(
-      await Nameserver.put({ id: testCase.id, name: 'b.ns.example.com.' }),
-    )
+    assert.ok(await Nameserver.put({ id: testCase.id, name: 'b.ns.example.com.' }))
     const ns = await Nameserver.get({ id: testCase.id })
     assert.deepEqual(ns[0].name, 'b.ns.example.com.')
     assert.ok(await Nameserver.put({ id: testCase.id, name: testCase.name }))