[IMP] subscription_oca:set invoice currency to subscription pricelist and ensure company context in create_invoice

[stferraro]

In multi-company and multi-currency setups, invoices generated from subscriptions may not consistently enforce:

The subscription pricelist currency on the created invoice.

The subscription company context during invoice creation.
This can lead to inconsistent invoice values or cross-company context issues in downstream implementations.

Describe the solution you'd like
Implement the following in subscription_oca:

1. Ensure invoice values explicitly set currency_id from subscription.pricelist_id.currency_id when preparing account.move values.

2. Ensure create_invoice runs under subscription.company_id context (with_company) before creating the invoice.

Also add unit tests to validate:

1. Invoice currency matches subscription pricelist currency.

2. Invoice company matches subscription company in multi-company scenarios.

3. Multi-Company Security: Ensure proper record rules are defined so users in multi-company environments don't face access errors or leakages.

Describe alternatives you've considered

1. Keep this behavior in downstream custom modules only.

2. Override invoice creation in each deployment that needs strict multi-company/multi-currency behavior.

These alternatives duplicate logic across projects and increase maintenance cost compared to handling it upstream.

Additional context
I can submit a PR for 19.0 including implementation and tests.

[stferraro]

Hi, @sbidoul @CristianoMafraJunior @thib-d @yvaucher check this functionality added to subscription oca and approve please

[stferraro]

Hi @rickard-w please checks this functionality please !

[stferraro]

@OCA-git-bot mainteiners contract approve

[stferraro]

/ocabot merge --no-bump

[OCA-git-bot]

Hi @stferraro. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

• ocabot merge major|minor|patch|nobump
• ocabot rebase
• ocabot migration {MODULE_NAME}

More information

• ocabot documentation
• OCA guidelines, specially the "Version Numbers" section.

[rickard-w]

Hi @stferraro
I have tried my best to force any issues with the subscription invoice. But as far as I can tell, everything seems to work as it should. Good job.

[stferraro]

Hi @rickard-w , thanks for your comment please approve this PR

[stferraro]

Hi @pedrobaeza, when you have a chance, could you please review this PR? Otherwise, could you tag someone who can review and approve it?

[rickard-w]

Hi @rickard-w , thanks for your comment please approve this PR

I don't have the permission to approve. And honstly, I don't know if I have the skills either :)