[IMP] subscription_oca: add multi-company security rules#1439
Open
alvaro-domatix wants to merge 1 commit into
Open
[IMP] subscription_oca: add multi-company security rules#1439alvaro-domatix wants to merge 1 commit into
alvaro-domatix wants to merge 1 commit into
Conversation
Without record rules, a salesman from company A could read or write subscriptions belonging to company B. This change adds record rules on sale.subscription and sale.subscription.line so that the salesman group only sees records whose company_id is in the user's allowed companies, matching the standard multi-company pattern used across OCA. The new security file is declared in the manifest before the ACL CSV so that rules are available as soon as access rights are created.
alvaro-domatix
force-pushed
the
19.0-imp-subscription_oca-multicompany-rules
branch
from
dc10651 to
ff1205c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Without record rules, a salesman from company A can read and write subscriptions belonging to company B. The module only ships ACLs in
ir.model.access.csvand noir.rulerecords, so multi-company isolation is missing for bothsale.subscriptionandsale.subscription.line.Solution
Add
security/subscription_security.xmlwith two non-global record rules attached to thesales_team.group_sale_salesmangroup:sale_subscription_company_rule: domain[('company_id', 'in', company_ids)].sale_subscription_line_company_rule: domain[('sale_subscription_id.company_id', 'in', company_ids)].The new security file is declared in the manifest before
security/ir.model.access.csvso the rules are available as soon as access rights are created.How to test
Run:
New test module
tests/test_subscription_security.pycovers:AccessErrorwhen reading a subscription or a line in company B.