[19.0][IMP] edi_core_oca: skip exchange types w/o handler in cron domains

[HviorForgeFlow]

Noticed while developing that when a exchange type is not linked to a handler and the EDINotImplementedError is raised, a DB rollback takes places undoing all previous work.

To ensure that skipping not handled exchanges does not break anything outside the cron scope I had to slightly change the exchange_generate_send method.

CC @etobella @simahawk @ForgeFlow

[OCA-git-bot]

Hi @etobella, @simahawk,
some modules you are maintaining are being modified, check this out!

[simahawk]

Wondering: why is it possible to handle an exc type w/o handler? It should be validated beforehand...

We should make specific validators required based on the direction.
And maybe improve _$direction_new_records_domain.

[HviorForgeFlow]

Wondering: why is it possible to handle an exc type w/o handler? It should be validated beforehand...

We should make specific validators required based on the direction. And maybe improve _$direction_new_records_domain.

That makes more sense, cleaner implementation, thanks for the advice

[HviorForgeFlow]

@simahawk it follows your suggested approach

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[simahawk]

@HviorForgeFlow I think you miss the part "specific validators required based on the direction."
Now that I see the change I'm not really a big fan of just the domain fix. Sorry 😇

What about adding validation and fixing the data the you have?
I mean, an exc type that has direction "output" and has no "generate" or "send" handler is definitely broken.
I'd rather:

• add validation on the exc type form (make some fields required based on direction)
• add an api.constraint

WDYT?