[18.0][FIX] fetchmail_attach_from_folder: case-insensitive email matching

[fsmw]

Bug

Closes #3402

Emails containing uppercase letters were not linked to partner records because the match algorithm lowercased the incoming email addresses but then searched with (case-sensitive exact match). If the partner stored the email as mixed-case (e.g. Name.SURNAME@Domain.com), the match failed.

Fix

Use Odoo's operator instead of . This matches Odoo's own approach in core ( line 965) and performs a case-insensitive exact match via PostgreSQL .

Changes

• : default operator changed from to
• : added covering uppercase email matching

Compatibility

• Fully backward compatible: existing exact matches still work; now uppercase variants also match.

[OCA-git-bot]

Hi @NL66278,
some modules you are maintaining are being modified, check this out!

[NL66278]

@fsmw I think the bug is valid and the problem real. However replacing an equal comparison = with ilike might run into a lot of other problems. Suppose a mail is fetched for fernando@example.com, and there is a partner with email Fernando@example.com in the database. Your solution will find this, but will also find Alexando-Fernando@example.com. So maybe better to encourage people to search on email_normalized instead of on email (and reflect this in the tests and examples). What do you think?

[fsmw]

Hi @NL66278, thanks for the review and the valid concern. Your suggestion has been incorporated:

• _get_mailaddresses() now uses Odoo's email_normalize() to normalize incoming addresses (strips display names, lowercases, handles edge cases).
• Since the search values are normalized and contain no % wildcards, =ilike functions exactly as a case-insensitive = — it won't match substrings.
• Added test coverage for partner stored with uppercase email and for display-name headers ("Name email@domain").

Let me know if anything else is needed.

[NL66278]

Is the or addr.lower() not superfluous here?