Skip to content

Add trexdb as a source dialect - #2579

Open
p-hoffmann wants to merge 4 commits into
masterfrom
p-hoffmann/trexsql-source
Open

p-hoffmann wants to merge 4 commits into
masterfrom
p-hoffmann/trexsql-source

Conversation

@p-hoffmann

@p-hoffmann p-hoffmann commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Lets a source use dialect trexdb with a jdbc:trexdb://host:port connection string (driver provided by the trexsql plugin); SQL is translated through a trexdb SqlRender target registered at startup.

The trexdb dialect is proposed for SqlRender itself in OHDSI/SqlRender#416 (OHDSI/SqlRender#416); once WebAPI uses a SqlRender release that includes it, the startup registration does nothing.

Sources can now use dialect trexsql with a jdbc:trexsql:// connection
string; the trexsql plugin provides the driver.

SqlRender has no trexsql target, so TrexsqlDialect registers one at startup
that reuses the patterns of the engine trexsql is built on. SqlTranslate
keeps one pattern table per JVM, so cohort and characterization SQL that is
translated inside libraries picks it up too.
@chrisknoll

Copy link
Copy Markdown
Collaborator

Let's discuss this before implementation.

The dialect is named after the database, trexdb, matching the trexdb
target proposed for SqlRender (OHDSI/SqlRender#416), so the DBMSType and
the SqlRender target name stay the same string. The jdbc:trexsql:// URL
scheme is the driver's and is unchanged.

register() now does nothing when the bundled SqlRender already has trexdb
patterns, so upgrading to a SqlRender release that ships the dialect does
not append a second copy.
@p-hoffmann p-hoffmann changed the title Add trexsql as a source dialect Add trexdb as a source dialect Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants