Skip to content

autotools: drop gnu99 as default#465

Merged
victorjulien merged 1 commit into
OISF:0.5.xfrom
victorjulien:c11/v1
May 20, 2026
Merged

autotools: drop gnu99 as default#465
victorjulien merged 1 commit into
OISF:0.5.xfrom
victorjulien:c11/v1

Conversation

@victorjulien
Copy link
Copy Markdown
Member

To address:

htp_util.c:623:32: warning: '_Generic' is a C11 extension [-Wc11-extensions]
623 | unsigned char *colon = memchr(data, ':', len);
| ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
122 | __glibc_const_generic (S, const void *, memchr (S, C, N))
| ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
838 | _Generic (0 ? (PTR) : (void *) 1,
| ^
htp_util.c:799:32: warning: '_Generic' is a C11 extension [-Wc11-extensions]
799 | unsigned char *m = memchr(data + start, '@', pos - start);
| ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
122 | __glibc_const_generic (S, const void *, memchr (S, C, N))
| ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
838 | _Generic (0 ? (PTR) : (void *) 1,
| ^
htp_util.c:810:21: warning: '_Generic' is a C11 extension [-Wc11-extensions]
810 | m = memchr(credentials_start, ':', credentials_len);
| ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
122 | __glibc_const_generic (S, const void *, memchr (S, C, N))
| ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
838 | _Generic (0 ? (PTR) : (void *) 1,
| ^
htp_util.c:832:21: warning: '_Generic' is a C11 extension [-Wc11-extensions]
832 | m = memchr(hostname_start, ']', hostname_len);
| ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
122 | __glibc_const_generic (S, const void *, memchr (S, C, N))
| ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
838 | _Generic (0 ? (PTR) : (void *) 1,
| ^
htp_util.c:846:25: warning: '_Generic' is a C11 extension [-Wc11-extensions]
846 | m = memchr(hostname_start, ':', hostname_len);
| ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
122 | __glibc_const_generic (S, const void *, memchr (S, C, N))
| ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
838 | _Generic (0 ? (PTR) : (void *) 1,
| ^
htp_util.c:856:21: warning: '_Generic' is a C11 extension [-Wc11-extensions]
856 | m = memchr(hostname_start, ':', hostname_len);
| ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
122 | __glibc_const_generic (S, const void *, memchr (S, C, N))
| ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
838 | _Generic (0 ? (PTR) : (void *) 1,
| ^
6 warnings generated.

@suricata-qa
Copy link
Copy Markdown

WARNING:
ERROR: buid failure for build_asan QA build

field baseline test %
build_asan

Pipeline = 31619

If c11 is not available, use gnu99 and suppress c11-extensions warnings.

To address:

htp_util.c:623:32: warning: '_Generic' is a C11 extension [-Wc11-extensions]
  623 |         unsigned char *colon = memchr(data, ':', len);
      |                                ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
  122 |   __glibc_const_generic (S, const void *, memchr (S, C, N))
      |   ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
  838 |   _Generic (0 ? (PTR) : (void *) 1,                     \
      |   ^
htp_util.c:799:32: warning: '_Generic' is a C11 extension [-Wc11-extensions]
  799 |             unsigned char *m = memchr(data + start, '@', pos - start);
      |                                ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
  122 |   __glibc_const_generic (S, const void *, memchr (S, C, N))
      |   ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
  838 |   _Generic (0 ? (PTR) : (void *) 1,                     \
      |   ^
htp_util.c:810:21: warning: '_Generic' is a C11 extension [-Wc11-extensions]
  810 |                 m = memchr(credentials_start, ':', credentials_len);
      |                     ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
  122 |   __glibc_const_generic (S, const void *, memchr (S, C, N))
      |   ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
  838 |   _Generic (0 ? (PTR) : (void *) 1,                     \
      |   ^
htp_util.c:832:21: warning: '_Generic' is a C11 extension [-Wc11-extensions]
  832 |                 m = memchr(hostname_start, ']', hostname_len);
      |                     ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
  122 |   __glibc_const_generic (S, const void *, memchr (S, C, N))
      |   ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
  838 |   _Generic (0 ? (PTR) : (void *) 1,                     \
      |   ^
htp_util.c:846:25: warning: '_Generic' is a C11 extension [-Wc11-extensions]
  846 |                     m = memchr(hostname_start, ':', hostname_len);
      |                         ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
  122 |   __glibc_const_generic (S, const void *, memchr (S, C, N))
      |   ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
  838 |   _Generic (0 ? (PTR) : (void *) 1,                     \
      |   ^
htp_util.c:856:21: warning: '_Generic' is a C11 extension [-Wc11-extensions]
  856 |                 m = memchr(hostname_start, ':', hostname_len);
      |                     ^
/usr/include/string.h:122:3: note: expanded from macro 'memchr'
  122 |   __glibc_const_generic (S, const void *, memchr (S, C, N))
      |   ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:838:3: note: expanded from macro '__glibc_const_generic'
  838 |   _Generic (0 ? (PTR) : (void *) 1,                     \
      |   ^
6 warnings generated.
@suricata-qa
Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 31620

@victorjulien victorjulien changed the title autotools: drop gnu99, require c11 autotools: drop gnu99 as default May 20, 2026
Copy link
Copy Markdown
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me :-)

@victorjulien victorjulien merged commit 2f29bd0 into OISF:0.5.x May 20, 2026
10 checks passed
@victorjulien
Copy link
Copy Markdown
Member Author

Merged in #466, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants