background rig calls#79
Open
SpudGunMan wants to merge 1 commit intoON4QZ:mainfrom
Open
Conversation
clean up exit and polling to stop freezing GUI
Collaborator
|
Sounds cool to me ;-) |
hspil
reviewed
Apr 18, 2026
Collaborator
hspil
left a comment
hspil
left a comment
There was a problem hiding this comment.
I don't know if we have a style and naming guide for this project, but getFreqErrorCount sounds like the name of a method. freqErrorCount is probably better for an int.
Otherwise, I'm in over my head and don't really understand what is going on, but a cursory skim looks fine.
Author
|
Let me know if I can:should do anything but yes it's the getFrequency,ErrorCount |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean up exit and polling to stop freezing GUI
if the idea isa handy :) 73