firefox: remove hard clang dependency#990
Open
OldManYellsAtCloud wants to merge 2 commits into
Open
Conversation
OldManYellsAtCloud
force-pushed
the
master
branch
3 times, most recently
from
a76fb56 to
dac0bab
Compare
Firefox compiles with gcc - remove the hardcoded clang dependency. New patches freebl-ignore-unused-arguments-during-configure.patch: A component is trying to remove some gcc warnings. OE adds -Wformat-security by default, but the component also adds -Wno-format, which cancels it out, but generates a warning (which is turned into an error): cc1plus: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security] To avoid this, the patch adds also -Wno-format-security explicitly. msgpack-enforce-endian-functionality.patch: Using gcc, the msgpack third party application can't determine the endianness of risc-v arch (at least not for qemuriscv64), failing the build. This issue has been fixed upstream a while ago, but not pulled into Firefox yet. This patch is a backport of that commit. llama.cpp-unknown-type-name-__fp16.patch: On 32-bit arm fp16 isn't defined by default. Added a patch taken from https://stackoverflow.com/questions/31242106/fp16-type-undefined-in-gnu-arm-c Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
The PARALLEL_MAKE OE variable has been ignored until now, Firefox was built with the number of jobs determined by mach (which is usually the number of CPU cores). To be able to control this number, pass the PARALLEL_MAKE variable value as a custom make flag to mach. Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
OldManYellsAtCloud
force-pushed
the
master
branch
from
dac0bab to
c5ea867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBH I don't remember anymore why I made initially Firefox require clang, unfortunately it was too long time ago.
But today I was curious if gcc works - and it does, it required only a minor patch.
This PR removes the hardcoded clang dependency from the Firefox recipe.
After this clang is only required if Firefox is built with sandboxed libraries enabled (this is the default, and can be changed with a
PACKAGECONFIG. This is due to wasi-sdk having a hard dependency on clang)When built without sandboxed libraries, clang can be avoided completely (at least from Firefox's point of view).
So far I tested successfully Scarthgap with glibc on x86-64, with both versions of Firefox. The rest of the test is left to the CI.