Skip to content

docs(website): clarify local scan privacy claim on homepage (#1496) - #1498

Merged
sonukapoor merged 1 commit into
OWASP:mainfrom
bhushan4work:1496
Nov 5, 2026
Merged

sonukapoor merged 1 commit into
OWASP:mainfrom
bhushan4work:1496

Conversation

@bhushan4work

@bhushan4work bhushan4work commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

summary

  • replaced the inaccurate "nothing leaves your machine" claim on the website homepage.
  • clarified that source code and lockfiles stay on the user's machine.
  • verified that no other pages under website/ repeat the old claim.

checks

  • npm run build (website)
  • npm run typecheck (website)
  • verified changes are limited to website/src/pages/index.tsx

closes #1496

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated the homepage to clarify that source code and lockfiles stay on your machine when running locally.

The homepage now states that source code and lockfiles stay on the user’s machine. This replaces the broader claim that nothing leaves the machine.

Changes: Homepage privacy wording

Layer / File(s) Summary
Update the Runs locally statement
website/src/pages/index.tsx
The “Runs locally” text now says that source code and lockfiles stay on the user’s machine.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • OWASP/cve-lite-cli#1489: This PR updates the README with privacy wording about local source code and lockfiles, matching the homepage change.
Merge Risk: Minimal · up to 791e7

The homepage now clarifies that source code and lockfiles stay local without claiming that no data leaves the machine. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 6 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Closes Keyword Matches Scope Warning The body uses Closes #1496. The homepage text is corrected, but the issue also requires no other page under website/ to repeat the old privacy claim. website/docs/best-practices.md:129 still say… Update or clarify website/docs/best-practices.md:129 so it does not repeat the ambiguous claim, then verify that website/ has no remaining leaves your machine match and rerun the required website build. If that documentation work is o…
Passed Passed checks: 6 passed
Check name Status Explanation
Title check Passed The title "docs(website): clarify local scan privacy claim on homepage (#1496)" matches the requirement form "type: short description" with the allowed type "docs". It describes the change to the home…
Description check Passed The description follows the repository template. It has a summary of what changed and why, plus a checks section that lists the npm build and typecheck runs and the scope limit to website/src/pages/in…
Linked Issues check Passed Issue #1496 requires a short, accurate homepage statement, no repeated "leaves your machine" claim under website/, and a passing website build. The homepage now says `Your source code and lockfiles …
Out of Scope Changes check Passed The change is limited to the homepage privacy statement in website/src/pages/index.tsx. This directly implements issue #1496. The reported website typecheck is supporting validation, not unrelated s…
Linked Issue Passed The pull request body includes “closes #1496”, which references GitHub issue #1496 with an accepted keyword and issue number.
No New Runtime Dependency Passed The pull request changes only the homepage text in website/src/pages/index.tsx. No package.json, lockfile, or other dependency manifest changes are present, so it adds no runtime dependency and mo…
Full details: Title check

Explanation

The title "docs(website): clarify local scan privacy claim on homepage (#1496)" matches the requirement form "type: short description" with the allowed type "docs". It describes the change to the homepage privacy claim in website/src/pages/index.tsx. The text is lowercase after the colon and has no trailing period. The title is 67 characters. The requirement does not mention a scope in parentheses, so the "(website)" scope is extra but does not break the required form. The issue number in the title is also extra but harmless.

Full details: Description check

Explanation

The description follows the repository template. It has a summary of what changed and why, plus a checks section that lists the npm build and typecheck runs and the scope limit to website/src/pages/index.tsx. It closes #1496 with the issue link. The template expects a "What changed and why" heading and a "Closes #" line, but the author used "summary" and "checks" headings and wrote "closes #1496". The required information is present, so the description is mostly complete.

Full details: Linked Issues check

Explanation

Issue #1496 requires a short, accurate homepage statement, no repeated "leaves your machine" claim under website/, and a passing website build. The homepage now says Your source code and lockfiles stay on your machine in website/src/pages/index.tsx. The PR summary reports the required site-wide search and a passing npm run build in website/.

Full details: Out of Scope Changes check

Explanation

The change is limited to the homepage privacy statement in website/src/pages/index.tsx. This directly implements issue #1496. The reported website typecheck is supporting validation, not unrelated scope.

Full details: No New Runtime Dependency

Explanation

The pull request changes only the homepage text in website/src/pages/index.tsx. No package.json, lockfile, or other dependency manifest changes are present, so it adds no runtime dependency and moves no package into dependencies.

Full details: Closes Keyword Matches Scope

Explanation

The body uses Closes #1496. The homepage text is corrected, but the issue also requires no other page under website/ to repeat the old privacy claim. website/docs/best-practices.md:129 still says “your source never leaves your machine,” and the search for leaves your machine still returns that page. The PR therefore does not deliver every issue item before auto-closing it.

Resolution

Update or clarify website/docs/best-practices.md:129 so it does not repeat the ambiguous claim, then verify that website/ has no remaining leaves your machine match and rerun the required website build. If that documentation work is out of scope, change Closes #1496 to Refs #1496.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Automatic approval policy

Commit: 791e7cb7fc29.

Setting Effective value Source
Automatic approvals Enabled Global configuration
Merge risk Moderate Global configuration
Security risk Not set Global configuration

No overrides matched. The global limits apply.

Not set means no limit was configured after inheritance. Use @coderabbitai configuration to inspect the resolved settings and their sources.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 98ed40e and 791e7cb.

Files selected for processing: 1
  • website/src/pages/index.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@sonukapoor sonukapoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhushan4work. The homepage line now says what is actually true, and the only other mention on the site is about source code, so that one stands. The README half is in #1489. Approved.

@sonukapoor
sonukapoor merged commit 509e475 into OWASP:main Nov 5, 2026
11 checks passed
@sonukapoor

Copy link
Copy Markdown
Collaborator

Merged - thank you @bhushan4work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(website): the homepage still says nothing leaves your machine

2 participants