Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/DEPENDENCY_DECISIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,39 @@ Credential scoping is the one release-path change this review cannot exercise
without the project's Central token. The first signed `clean deploy` under 3.10.0
should confirm that staging still authenticates before the release relies on it.

## Guava and OpenTelemetry build/test pins — 2026-11-16

[GHSA-xxph-c9ww-hj94](https://github.com/advisories/GHSA-xxph-c9ww-hj94)
affects Guava through 33.7.1 and is fixed in **33.7.2**.
[GHSA-ccrj-gw8r-854m](https://github.com/advisories/GHSA-ccrj-gw8r-854m)
affects OpenTelemetry Java through 1.66.0 and is fixed in **1.67.0**. GitHub
reported both only on build-plugin realms and the unpublished Jakarta fixture's
test classpath. No published library depends on either.

Guava 33.7.2-jre is pinned directly in each executed plugin realm that brought an
affected copy: Checkstyle 12.3.1 (33.5.0) in the root and fixture builds, the
japicmp engine run by `exec-maven-plugin` (33.4.8), `central-publishing-maven-plugin`
(32.1.0, pinned in plugin management so the release profile's existing publisher
mitigations still merge with it), and the fixture's WAR plugin through Guice
(33.4.8). In the fixture, Selenium 4.49.0 brings Guava 33.7.1, so its dependency
management pins 33.7.2-jre, and the `opentelemetry.version` property raises Boot
4.1.2's managed OpenTelemetry BOM from 1.62.0 to 1.67.0 for Selenium's tracing.

Selenium stays on 4.49.0 because the client is aligned with the digest-pinned
browser image. Selenium 4.52.0 already depends on Guava 33.7.2 and OpenTelemetry
1.67.0, so a later reviewed client-and-image update can drop the fixture's
dependency-management pin; drop the OpenTelemetry property once Boot manages
1.67.0 or newer. Remove each plugin-realm Guava pin when that plugin's own graph
reaches 33.7.2. `kotlin-maven-plugin` appears in the fixture's resolved plugin
list with Guava 33.5.0 through Boot's plugin management, but the fixture never
executes it and the dependency submission does not include it.

`./mvnw verify` exercises the new Guava in the Checkstyle and japicmp realms,
and packaging the fixture exercises it in the fixture's Checkstyle and WAR
realms. The publisher realm was resolved, not executed, because there is no
publishing run that skips signing and Central credentials. The next signed
release rehearsal should confirm it before a release relies on it.

## Deferred proposals and reconsideration conditions

| Proposal | Disposition and required evidence before reconsideration |
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ unchanged. [1.6.0 is available from Central](releases/1.6.0-central-publication.
exceeds. Refresh Maven build plugins, plexus-archiver, japicmp, and the
test/publisher-only Jackson 2.22.4. Published library dependencies are
unchanged.
- Pin Guava 33.7.2 in the Checkstyle, japicmp, WAR and Central publisher
plugin realms and the Jakarta fixture's Selenium tests, and raise the
fixture's OpenTelemetry to 1.67.0, for GHSA-xxph-c9ww-hj94 and
GHSA-ccrj-gw8r-854m. Published library dependencies are unchanged.

## 1.6.0 — 2026-10-18 UTC

Expand Down
7 changes: 5 additions & 2 deletions jakarta-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ A local Chrome-only diagnostic for the JavaScript suite remains available with

As reviewed on 2026-10-26, this fixture uses supported Spring Boot **4.1.2** and
its managed dependencies, on JDK **17**, with Tomcat/Jasper **11.0.27**
(Servlet **6.1**, Pages **4.0**, EL **6.0**). The one deliberate BOM override is
Selenium 4.49.0, aligned with the current reviewed browser image.
(Servlet **6.1**, Pages **4.0**, EL **6.0**). The deliberate BOM override is
Selenium 4.49.0, aligned with the current reviewed browser image. Its test-only
Guava (**33.7.2**) and OpenTelemetry (**1.67.0**) are raised to the first
releases that fix GHSA-xxph-c9ww-hj94 and GHSA-ccrj-gw8r-854m; see the
[dependency decisions](../.github/DEPENDENCY_DECISIONS.md).
Testcontainers **2.0.5**, JSTL API **3.0.2** and implementation **3.0.1** follow the
Boot BOM. The standalone Servlet/Pages/EL API JARs are removed; Tomcat supplies
the coherent implementation/API set. Both JSTL components remain packaged.
Expand Down
13 changes: 13 additions & 0 deletions jakarta-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,19 @@
<java.version>17</java.version>
<!-- Keep the client aligned with the reviewed, digest-pinned browser image. -->
<selenium.version>4.49.0</selenium.version>
<!-- GHSA-ccrj-gw8r-854m: Boot 4.1.2 manages OpenTelemetry 1.62.0, which
Selenium's test-only tracing uses. 1.67.0 is the first fixed release. -->
<opentelemetry.version>1.67.0</opentelemetry.version>
<!-- Must equal the version in the root pom.xml so this app tests the
encoder-jakarta-jsp built in the same reactor. CI checks this. -->
<encoder.version>1.6.1-SNAPSHOT</encoder.version>
</properties>
<dependencyManagement>
<dependencies>
<!-- GHSA-xxph-c9ww-hj94: Selenium 4.49.0 brings Guava 33.7.1 (test only). -->
<dependency><groupId>com.google.guava</groupId><artifactId>guava</artifactId><version>33.7.2-jre</version></dependency>
</dependencies>
</dependencyManagement>
<dependencies>
<dependency>
<groupId>org.owasp.encoder</groupId>
Expand Down Expand Up @@ -114,6 +123,8 @@
<dependency><groupId>org.apache.commons</groupId><artifactId>commons-lang3</artifactId><version>3.22.0</version></dependency>
<dependency><groupId>org.codehaus.plexus</groupId><artifactId>plexus-archiver</artifactId><version>4.15.0</version></dependency>
<dependency><groupId>org.codehaus.plexus</groupId><artifactId>plexus-utils</artifactId><version>4.0.3</version></dependency>
<!-- GHSA-xxph-c9ww-hj94: Checkstyle 12.3.1 brings Guava 33.5.0. -->
<dependency><groupId>com.google.guava</groupId><artifactId>guava</artifactId><version>33.7.2-jre</version></dependency>
</dependencies>
<configuration>
<configLocation>${maven.multiModuleProjectDirectory}/src/main/config/checkstyle.xml</configLocation>
Expand Down Expand Up @@ -190,6 +201,8 @@
<dependencies>
<dependency><groupId>org.codehaus.plexus</groupId><artifactId>plexus-archiver</artifactId><version>4.15.0</version></dependency>
<dependency><groupId>org.codehaus.plexus</groupId><artifactId>plexus-utils</artifactId><version>4.0.3</version></dependency>
<!-- GHSA-xxph-c9ww-hj94: the WAR plugin's Guice brings Guava 33.4.8. -->
<dependency><groupId>com.google.guava</groupId><artifactId>guava</artifactId><version>33.7.2-jre</version></dependency>
</dependencies>
</plugin>
<plugin>
Expand Down
8 changes: 8 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,8 @@
<artifactId>japicmp</artifactId>
<version>0.27.0</version>
</dependency>
<!-- GHSA-xxph-c9ww-hj94: japicmp brings Guava 33.4.8. -->
<dependency><groupId>com.google.guava</groupId><artifactId>guava</artifactId><version>33.7.2-jre</version></dependency>
</dependencies>
<executions>
<execution>
Expand Down Expand Up @@ -375,6 +377,10 @@
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<version>0.12.0</version>
<dependencies>
<!-- GHSA-xxph-c9ww-hj94: the publisher brings Guava 32.1.0. -->
<dependency><groupId>com.google.guava</groupId><artifactId>guava</artifactId><version>33.7.2-jre</version></dependency>
</dependencies>
</plugin>
</plugins>
</pluginManagement>
Expand Down Expand Up @@ -416,6 +422,8 @@
<dependency><groupId>org.apache.commons</groupId><artifactId>commons-lang3</artifactId><version>3.22.0</version></dependency>
<dependency><groupId>org.codehaus.plexus</groupId><artifactId>plexus-archiver</artifactId><version>4.15.0</version></dependency>
<dependency><groupId>org.codehaus.plexus</groupId><artifactId>plexus-utils</artifactId><version>4.0.3</version></dependency>
<!-- GHSA-xxph-c9ww-hj94: Checkstyle 12.3.1 brings Guava 33.5.0. -->
<dependency><groupId>com.google.guava</groupId><artifactId>guava</artifactId><version>33.7.2-jre</version></dependency>
</dependencies>
<configuration>
<configLocation>${maven.multiModuleProjectDirectory}/src/main/config/checkstyle.xml</configLocation>
Expand Down
Loading