Luke/event driven script orchestrator#966
Draft
LukeButters wants to merge 35 commits intomainfrom
Draft
Conversation
00b754a to
33bb1b4
Compare
# Conflicts: # source/Octopus.Tentacle.Client/Scripts/KubernetesScriptServiceV1AlphaOrchestrator.cs # source/Octopus.Tentacle.Client/Scripts/ScriptOrchestratorFactory.cs # source/Octopus.Tentacle.Client/TentacleClient.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
[SC-82375]
Currently we only allow calling into tentacle client to run a script via the TentacleClient.ExecuteScript method. Although extremely simple it is not re-entrant. When we talk about re-entrancy we are considding the case the client gets turned off and on and wants to continue on. The deficiencies are:
Results
This spikes out a tentacle client which can be driven by an event driven orchestrator which helps addresses those deficiencies.
In summary the changes are:
AggregateScriptExecutor