micro-opmtimise address-filter hashing implementation - NIT-4757#4600
Merged
joshuacolvin0 merged 3 commits intomasterfrom Apr 6, 2026
Merged
micro-opmtimise address-filter hashing implementation - NIT-4757#4600joshuacolvin0 merged 3 commits intomasterfrom
joshuacolvin0 merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
will update destination branch after destination PR get merged. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4600 +/- ##
==========================================
- Coverage 34.33% 34.00% -0.34%
==========================================
Files 498 494 -4
Lines 59085 58932 -153
==========================================
- Hits 20286 20038 -248
- Misses 35218 35349 +131
+ Partials 3581 3545 -36 |
Base automatically changed from
implement-string-hashing-for-address-filtering
to
master
April 3, 2026 16:21
Contributor
❌ 10 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
joshuacolvin0
requested changes
Apr 6, 2026
| } | ||
|
|
||
| hash := HashWithSalt(data.salt, addr) | ||
| hash := HashWithPrefix(GetHashInputPrefix(data.salt), addr) |
Member
There was a problem hiding this comment.
Probably better to use data.hashInputPrefix here to test the cached field?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title, address NIT-4757.