Fixes review nitpick

[LiquidityC]

Summary by CodeRabbit

• Bug Fixes

  • Improved profiler macro robustness to ensure correct behavior when used within conditional statements and loops.

• Chores

  • Refined profiler compilation guards and internal macro structure for more reliable conditional inclusion.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86b6a786-8224-4184-a219-f6d827b782dc

📥 Commits

Reviewing files that changed from the base of the PR and between aaa9047 and 113c9e1.

📒 Files selected for processing (1)

• lib/profiler/include/macros.h

---

📝 Walkthrough

Walkthrough

The profiler header is updated with an explicit #ifdef PROFILER guard block and the PROFILER_STOP(fp) macro is refactored from sequential bare statements to a do-while(0) compound statement pattern, which ensures safer macro expansion in all control-flow contexts.

Changes

Cohort / File(s)	Summary
Profiler Macro Safety lib/profiler/include/macros.h	Added explicit #ifdef PROFILER guard block; refactored PROFILER_STOP(fp) macro to use do-while(0) pattern instead of sequential statements for safer expansion in conditional contexts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Introduces self stopping profiler macros. #166: Directly modifies the same profiler header macros, particularly PROFILER_STOP in lib/profiler/include/macros.h.

Poem

🐰 A macro guard now stands so tall,
Do-while wraps the calls in shawl,
No dangling statements left alone,
Safety found in patterns shown!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fixes review nitpick' is vague and does not clearly convey what the actual change is—it refers to addressing feedback but doesn't describe the substantive modification to the PROFILER_STOP macro.	Revise the title to be more descriptive, such as 'Wrap PROFILER_STOP macro in do-while block for proper statement semantics' to clearly communicate the technical change being made.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rabbit_fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}