Skip to content

Fixed draggable clone incorrect size #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GarethBlain wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixed draggable clone incorrect size #43

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
667082f
Position drag element relative to mousedown on original draggable ele…
JGregoryAtiba Feb 26, 2016
a202ddd
CSS-class to identify zones that are possible to drop on on drag start.
Nov 18, 2016
3f7867e
Fixed draggable clone incorrect size
May 26, 2017
ce07b15
Merge pull request #1 from kgjersda/master
Jun 12, 2017
bda25db
Merge pull request #2 from jmgregory/Issue-34-drag-element-position-w…
Jun 12, 2017
9318a02
Moved popup model onto body and copied CSS over it so it doesn't effe…
Jun 13, 2017
30b1a44
Revert "Position drag element relative to mousedown on original dragg…
Jun 14, 2017
da3ac89
Merge pull request #3 from GarethBlain/revert-2-Issue-34-drag-element…
Jun 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/knockout.dragdrop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
this.dragEnter = args.dragEnter;
this.dragOver = args.dragOver;
this.dragLeave = args.dragLeave;
this.possibleOnDrag = args.possibleOnDrag;
this.active = false;
this.inside = false;
this.dirty = false;
Expand Down Expand Up @@ -173,8 +174,13 @@
}
DropZone.prototype = Zone.prototype;

DropZone.prototype.removePossibleDrag = function() {
toggleClass(this.element, 'drag-possible', false);
}

DropZone.prototype.updateStyling = function () {
if (this.dirty) {
toggleClass(this.element, 'drag-possible', this.possibleOnDrag);
toggleClass(this.element, 'drag-over', this.active);
toggleClass(this.element, 'drop-rejected', this.inside && !this.active);
}
Expand Down Expand Up @@ -270,6 +276,7 @@

forEach(dropZones[name], function (zone) {
zone.updateStyling();
zone.removePossibleDrag();
});

if (winningDropZone && winningDropZone.drop) {
Expand Down Expand Up @@ -394,6 +401,7 @@
element: element,
data: data,
drop: options.drop,
possibleOnDrag: options.possibleOnDrag,
dragEnter: options.dragEnter,
dragOver: options.dragOver,
dragLeave: options.dragLeave
Expand Down Expand Up @@ -476,12 +484,13 @@

function createCloneProxyElement() {
var dragProxy = element.cloneNode(true);
element.parentNode.appendChild(dragProxy);
var style = window.getComputedStyle(element, null);
dragProxy.style.height = style.getPropertyValue('height');
dragProxy.style.width = style.getPropertyValue('width');
dragProxy.style.opacity = 70 / 100;
dragProxy.style.filter = 'alpha(opacity=70)';
document.body.appendChild(dragProxy);
dragProxy.style.cssText = document.defaultView.getComputedStyle(element, "").cssText;
return dragProxy;
}

Expand Down