Skip to content

chore: drop redundant references in write! args #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OneNoted merged 2 commits into from
Nov 13, 2026
Merged

chore: drop redundant references in write! args #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47f570d
chore: drop redundant references in write! args
xqqmdy Oct 30, 2026
483ad58
chore: iterate bar heights directly in the OSD renderer
OneNoted Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/bin/whispers-osd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ impl BarState {
let rms_target = (rms * 4.0).min(1.0);
self.smooth_rms = self.smooth_rms * 0.85 + rms_target * 0.15;

for i in 0..NUM_BARS {
for (i, height) in self.heights.iter_mut().enumerate() {
let t = i as f32 / NUM_BARS as f32;
let wave1 = (t * std::f32::consts::PI * 2.0 + time * 2.0).sin() * 0.5 + 0.5;
let wave2 = (t * std::f32::consts::PI * 1.5 - time * 1.2).sin() * 0.3 + 0.5;
Expand All @@ -135,12 +135,12 @@ impl BarState {
let combined = (wave1 * 0.55 + wave2 * 0.30 + wave3 * 0.15) * level;
let target = BAR_MIN_HEIGHT + combined * (BAR_MAX_HEIGHT - BAR_MIN_HEIGHT);

if target > self.heights[i] {
self.heights[i] += (target - self.heights[i]) * RISE_RATE;
if target > *height {
*height += (target - *height) * RISE_RATE;
} else {
self.heights[i] = self.heights[i] * DECAY_RATE + target * (1.0 - DECAY_RATE);
*height = *height * DECAY_RATE + target * (1.0 - DECAY_RATE);
}
self.heights[i] = self.heights[i].clamp(BAR_MIN_HEIGHT, BAR_MAX_HEIGHT);
*height = height.clamp(BAR_MIN_HEIGHT, BAR_MAX_HEIGHT);
}
}
}
Expand Down Expand Up @@ -768,9 +768,9 @@ fn render_meter_bars(
let glow_expand = 1 + (color_t * 2.0) as u32;
let glow_alpha = (15.0 + color_t * 25.0) as u8;

for i in 0..NUM_BARS {
for (i, &height) in bars.heights.iter().enumerate() {
let bx = start_x + i as u32 * (BAR_WIDTH + BAR_GAP);
let bar_h = bars.heights[i] as u32;
let bar_h = height as u32;
let half_h = bar_h / 2;
let top_y = center_y.saturating_sub(half_h);

Expand Down Expand Up @@ -803,9 +803,9 @@ fn render_voice_bars(
center_y: u32,
start_x: u32,
) {
for i in 0..NUM_BARS {
for (i, &height) in bars.heights.iter().enumerate() {
let bx = start_x + i as u32 * (BAR_WIDTH + BAR_GAP);
let bar_h = bars.heights[i] as u32;
let bar_h = height as u32;
let half_h = bar_h / 2;
let top_y = center_y.saturating_sub(half_h);

Expand Down
8 changes: 4 additions & 4 deletions src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ impl Theme for ConfirmTheme {
write!(
f,
"{} {} ",
&self.base.prompt_prefix,
self.base.prompt_prefix,
self.base.prompt_style.apply_to(prompt)
)?;
}
Expand All @@ -220,7 +220,7 @@ impl Theme for ConfirmTheme {
brackets.apply_to("/"),
no,
brackets.apply_to("]"),
&self.base.prompt_suffix
self.base.prompt_suffix
),
Some(true) => write!(
f,
Expand All @@ -230,7 +230,7 @@ impl Theme for ConfirmTheme {
brackets.apply_to("/"),
no,
brackets.apply_to("]"),
&self.base.prompt_suffix,
self.base.prompt_suffix,
self.base.defaults_style.apply_to("yes")
),
Some(false) => write!(
Expand All @@ -241,7 +241,7 @@ impl Theme for ConfirmTheme {
brackets.apply_to("/"),
no_default,
brackets.apply_to("]"),
&self.base.prompt_suffix,
self.base.prompt_suffix,
self.base.defaults_style.apply_to("no")
),
}
Expand Down
Loading