Skip to content

packaging: set CARGO_TARGET_DIR in PKGBUILD - #38

Open
xqqmdy wants to merge 1 commit into
OneNoted:mainfrom
xqqmdy:fix/pkgbuild-global-target-dir
Open

xqqmdy wants to merge 1 commit into
OneNoted:mainfrom
xqqmdy:fix/pkgbuild-global-target-dir

Conversation

@xqqmdy

@xqqmdy xqqmdy commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Export CARGO_TARGET_DIR=target in build() so the binary always lands in $srcdir/whispers/target/release, regardless of build.target-dir set in the user's ~/.cargo/config.toml. Without this, package() fails with "cannot stat 'target/release/whispers'".

Also limit cargo fetch to the host triple, per the Arch Rust package guidelines.

Export CARGO_TARGET_DIR=target in build() so the binary always lands in
$srcdir/whispers/target/release, regardless of build.target-dir set in
the user's ~/.cargo/config.toml. Without this, package() fails with
"cannot stat 'target/release/whispers'".

Also limit `cargo fetch` to the host triple, per the Arch Rust package
guidelines.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b850a389-5c4a-4500-92d1-6643e44965da
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@xqqmdy

xqqmdy commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

BTW, the PKGBUILD published on the AUR (0.2.1.r0.g8992b01-1, last updated 2026-04-12) still passes the removed features local-rewrite,osd and its dependency list is outdated after the 0.3.0 refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant