Repository navigation
fix: use vmalloc for temporary metadata segment buffers - #993
Merged
Merged
Conversation
fix/metadata-vmalloc Signed-off-by: Woart <46750383+Woart@users.noreply.github.com>
Contributor
Author
|
I've submitted the fix as #993, using env_vmalloc() / env_vfree() as suggested. |
robertbaldyga
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
env_malloc()/env_free()withenv_vmalloc()/env_vfree()for temporary metadata segment buffers.The existing
kmalloc()allocation can fail withENOMEMunder severe physical memory fragmentation, preventing Open CAS from loading cache metadata despite sufficient available RAM.Temporary metadata copies do not require physically contiguous memory. The change also avoids unnecessary buffer zeroing.
Validation
Tested on Open CAS 26.09, Ubuntu 24.04, Linux 6.8.0-147-generic:
The fix follows the approach suggested by the maintainer in the related bug report.
Related issue: Open-CAS/open-cas-linux#1837