Repository navigation
fix(macos): recover from notarization ticket service failures - #1432
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Intel release run 42524354816 passed signing, Apple notarization, stapling, and all 62 Qt tests, then failed when ticket validation returned exit 68. The packaging script now retries only stapler's ticket-service error with bounded backoff and preserves redacted diagnostics. Missing, invalid, or revoked tickets still fail immediately.
Use the GitHub runner maintainer's documented TCP transport workaround only on the disposable Intel runner (actions/runner-images#14924). Relocated-package validation reuses the same retry owner; all signature, notarization, Gatekeeper, and package checks remain required.
Validation: 40 macOS tests run (39 passed, one expected Linux-only skip), 24 workflow tests passed, actionlint and diff checks passed. Independent review found no actionable issues. Regression tests cover transient recovery, exhausted retries, rejected tickets, timeouts, and secret redaction. A production rerun is still required to validate the hosted Intel network path.