Skip to content

fix(macos): recover from notarization ticket service failures - #1432

Merged
Kief5555 merged 1 commit into
devfrom
codex/macos-ticket-reliability
Nov 8, 2026
Merged

Kief5555 merged 1 commit into
devfrom
codex/macos-ticket-reliability

Conversation

@Kief5555

@Kief5555 Kief5555 commented Nov 8, 2026

Copy link
Copy Markdown
Member

Intel release run 42524354816 passed signing, Apple notarization, stapling, and all 62 Qt tests, then failed when ticket validation returned exit 68. The packaging script now retries only stapler's ticket-service error with bounded backoff and preserves redacted diagnostics. Missing, invalid, or revoked tickets still fail immediately.

Use the GitHub runner maintainer's documented TCP transport workaround only on the disposable Intel runner (actions/runner-images#14924). Relocated-package validation reuses the same retry owner; all signature, notarization, Gatekeeper, and package checks remain required.

Validation: 40 macOS tests run (39 passed, one expected Linux-only skip), 24 workflow tests passed, actionlint and diff checks passed. Independent review found no actionable issues. Regression tests cover transient recovery, exhausted retries, rejected tickets, timeouts, and secret redaction. A production rerun is still required to validate the hosted Intel network path.

@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b960aba0-f7dd-4131-baed-187baff11d0c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T21:59:45.587783Z acacabd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 1 other finding in Capy.

Open in Capy

@Kief5555
Kief5555 merged commit 1ce8a38 into dev Nov 8, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant